diff options
author | Rémy Coutable <remy@rymai.me> | 2018-06-26 07:57:21 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-06-26 07:57:21 +0000 |
commit | d2bba30f42cc21059b504439b3e626e70e035176 (patch) | |
tree | bc9bb70f588110529c99d2fa327d19ea89fc8332 | |
parent | 701adc21d6d5e523684ffc8078a4abb6e068e5a3 (diff) | |
parent | 0d22b2141f4ba9f75039d9614027b99946f35622 (diff) | |
download | gitlab-ce-d2bba30f42cc21059b504439b3e626e70e035176.tar.gz |
Merge branch 'update_project_flash_error_message' into 'master'
Set flash error message only for current request when updating project
Closes #43772
See merge request gitlab-org/gitlab-ce!20126
-rw-r--r-- | app/controllers/projects_controller.rb | 2 | ||||
-rw-r--r-- | spec/controllers/projects_controller_spec.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb index efb30ba4715..c2492a137fb 100644 --- a/app/controllers/projects_controller.rb +++ b/app/controllers/projects_controller.rb @@ -63,7 +63,7 @@ class ProjectsController < Projects::ApplicationController redirect_to(edit_project_path(@project)) end else - flash[:alert] = result[:message] + flash.now[:alert] = result[:message] format.html { render 'edit' } end diff --git a/spec/controllers/projects_controller_spec.rb b/spec/controllers/projects_controller_spec.rb index 90e698925b6..27f04be3fdf 100644 --- a/spec/controllers/projects_controller_spec.rb +++ b/spec/controllers/projects_controller_spec.rb @@ -329,7 +329,7 @@ describe ProjectsController do expect { update_project path: 'renamed_path' } .not_to change { project.reload.path } - expect(controller).to set_flash[:alert].to(/container registry tags/) + expect(controller).to set_flash.now[:alert].to(/container registry tags/) expect(response).to have_gitlab_http_status(200) end end |