summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDJ Mountney <dmountney@perforce.com>2015-03-19 13:51:16 -0700
committerDJ Mountney <dmountney@perforce.com>2015-03-19 13:51:16 -0700
commit415517918eca22dff524b5ce3ad48cb852887065 (patch)
tree5c9a4a2df9a20536cc2b3c6ce366cefa32c21256
parent476199e0691edd956764ace45264511048fe6eb1 (diff)
downloadgitlab-ce-415517918eca22dff524b5ce3ad48cb852887065.tar.gz
Update merge_status state to allow more transitions
Previously you could only transition from the unchecked state to one of the others. This meant that the mark_as_unmerged call in AutoMergeService would rarily be able to actually transition the state. As it would usually have already been set to can_be_merged before it hit that service.
-rw-r--r--app/models/merge_request.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index 4cbdc612297..798306f6dcc 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -95,11 +95,11 @@ class MergeRequest < ActiveRecord::Base
end
event :mark_as_mergeable do
- transition unchecked: :can_be_merged
+ transition [:unchecked, :cannot_be_merged] => :can_be_merged
end
event :mark_as_unmergeable do
- transition unchecked: :cannot_be_merged
+ transition [:unchecked, :can_be_merged] => :cannot_be_merged
end
state :unchecked