diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-06-29 21:24:40 +0000 |
|---|---|---|
| committer | Fatih Acet <acetfatih@gmail.com> | 2016-06-29 21:24:40 +0000 |
| commit | fd0aa35d9274bed420bad54adf3008175d410e0b (patch) | |
| tree | 5d04c6a540e1b429546991886ec14437d7de7887 | |
| parent | 84113d7e725dcf6f9a3945853475f0cede957fec (diff) | |
| parent | 8a27e8bb047ed45081a79f0a1429597c8f494299 (diff) | |
| download | gitlab-ce-fd0aa35d9274bed420bad54adf3008175d410e0b.tar.gz | |
Merge branch '19184-turn-off-autocomplete-on-label-dropdown-for-issues-mr-s' into 'master'
Disabled native autocomplete for dropdown filter inputs
## What does this MR do?
Disables native autocomplete for the dropdown filter inputs.
## Are there points in the code the reviewer needs to double check?
Did we want this on all dropdown filter inputs? The issue specifies only the 'label' filter input but I think it is relevant for any filter input?
## Why was this MR needed?
No need for native autocomplete.
## What are the relevant issue numbers?
Closes #19184
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4974
| -rw-r--r-- | app/helpers/dropdowns_helper.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/helpers/dropdowns_helper.rb b/app/helpers/dropdowns_helper.rb index 6b617e1730a..7c140538012 100644 --- a/app/helpers/dropdowns_helper.rb +++ b/app/helpers/dropdowns_helper.rb @@ -69,7 +69,7 @@ module DropdownsHelper def dropdown_filter(placeholder, search_id: nil) content_tag :div, class: "dropdown-input" do - filter_output = search_field_tag search_id, nil, class: "dropdown-input-field", placeholder: placeholder + filter_output = search_field_tag search_id, nil, class: "dropdown-input-field", placeholder: placeholder, autocomplete: 'off' filter_output << icon('search', class: "dropdown-input-search") filter_output << icon('times', class: "dropdown-input-clear js-dropdown-input-clear", role: "button") |