summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Greiling <mike@pixelcog.com>2017-03-02 00:35:44 -0600
committerMike Greiling <mike@pixelcog.com>2017-03-03 16:47:38 -0600
commitba865db378b12265442c008a6fc167f2c3c910fb (patch)
tree0febff45704bddbf0b02e00785d97839bc92bc15
parent7371f6cd8c168df41e4197f80f53f3c04185dee7 (diff)
downloadgitlab-ce-ba865db378b12265442c008a6fc167f2c3c910fb.tar.gz
separate webpack runtime into its own chunk to maintain cacheability of common chunk
-rw-r--r--app/views/layouts/_head.html.haml1
-rw-r--r--config/webpack.config.js5
2 files changed, 3 insertions, 3 deletions
diff --git a/app/views/layouts/_head.html.haml b/app/views/layouts/_head.html.haml
index 29844b1027b..8457d3fd0e2 100644
--- a/app/views/layouts/_head.html.haml
+++ b/app/views/layouts/_head.html.haml
@@ -28,6 +28,7 @@
= stylesheet_link_tag "application", media: "all"
= stylesheet_link_tag "print", media: "print"
+ = javascript_include_tag(*webpack_asset_paths("manifest"))
= javascript_include_tag(*webpack_asset_paths("common"))
= javascript_include_tag(*webpack_asset_paths("application"))
diff --git a/config/webpack.config.js b/config/webpack.config.js
index a76daa2ba95..f262286f5f8 100644
--- a/config/webpack.config.js
+++ b/config/webpack.config.js
@@ -98,10 +98,9 @@ var config = {
new webpack.HashedModuleIdsPlugin() :
new webpack.NamedModulesPlugin(),
- // create a common.js bundle to be loaded on every page
+ // create cacheable common library bundles
new webpack.optimize.CommonsChunkPlugin({
- name: 'common',
- minChunks: Infinity,
+ names: ['application', 'common', 'manifest'],
}),
],