summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorConnor Shea <connor.james.shea@gmail.com>2016-08-15 11:18:48 -0600
committerConnor Shea <connor.james.shea@gmail.com>2016-08-15 11:18:48 -0600
commit1595047777ea035d2b8bddbd3a07a1bc68b58c55 (patch)
treee085aba80fd8328cb74ca22cb4c6279905f52b1c
parentc770201061c5d39e6e297951badfafc8ddf14906 (diff)
downloadgitlab-ce-1595047777ea035d2b8bddbd3a07a1bc68b58c55.tar.gz
Single quotes for consistency, cache 'this' selector.
-rw-r--r--app/assets/javascripts/application.js7
1 files changed, 4 insertions, 3 deletions
diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 6c44b76c5fe..cc1042c92b8 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -223,9 +223,10 @@
return $('.navbar-toggle').toggleClass('active');
});
$body.on("click", ".js-toggle-diff-comments", function(e) {
- $(this).toggleClass('active');
- var notesHolders = $(this).closest(".diff-file").find(".notes_holder");
- if ($(this).hasClass('active')) {
+ var $this = $(this);
+ $this.toggleClass('active');
+ var notesHolders = $this.closest('.diff-file').find('.notes_holder');
+ if ($this.hasClass('active')) {
notesHolders.show();
} else {
notesHolders.hide();