summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlfredo Sumaran <alfredo@gitlab.com>2017-06-08 02:34:38 -0500
committerAlfredo Sumaran <alfredo@gitlab.com>2017-06-08 02:34:38 -0500
commit2a33752cb4b3a19cf51cd3a97feec892f750ba6f (patch)
tree8039685a9d3b0e511192e7bb19fac9d2e8c2caf7
parentec7f906b563707c40280a8c73ac00f737ffb85f5 (diff)
downloadgitlab-ce-2a33752cb4b3a19cf51cd3a97feec892f750ba6f.tar.gz
Add missing aria-hidden attribute to i tags
-rw-r--r--app/assets/javascripts/groups/components/group_item.vue29
1 files changed, 21 insertions, 8 deletions
diff --git a/app/assets/javascripts/groups/components/group_item.vue b/app/assets/javascripts/groups/components/group_item.vue
index 0468491b6b6..32815b9f73e 100644
--- a/app/assets/javascripts/groups/components/group_item.vue
+++ b/app/assets/javascripts/groups/components/group_item.vue
@@ -110,7 +110,11 @@ export default {
v-if="group.canEdit"
class="edit-group btn"
:href="group.editPath">
- <i aria-hidden="true" class="fa fa-cogs"></i>
+ <i
+ class="fa fa-cogs"
+ aria-hidden="true"
+ >
+ </i>
</a>
<a
@click="onLeaveGroup"
@@ -118,8 +122,9 @@ export default {
class="leave-group btn"
title="Leave this group">
<i
+ class="fa fa-sign-out"
aria-hidden="true"
- class="fa fa-sign-out">
+ >
</i>
</a>
</div>
@@ -128,24 +133,27 @@ export default {
<span
class="number-projects">
<i
+ class="fa fa-bookmark"
aria-hidden="true"
- class="fa fa-bookmark">
+ >
</i>
{{group.numberProjects}}
</span>
<span
class="number-users">
<i
+ class="fa fa-users"
aria-hidden="true"
- class="fa fa-users">
+ >
</i>
{{group.numberUsers}}
</span>
<span
class="group-visibility">
<i
+ :class="visibilityIcon"
aria-hidden="true"
- :class="visibilityIcon">
+ >
</i>
</span>
</div>
@@ -156,18 +164,23 @@ export default {
v-if="group.hasSubgroups">
<i
v-if="group.isOpen"
- class="fa fa-caret-down">
+ class="fa fa-caret-down"
+ aria-hidden="true"
+ >
</i>
<i
v-if="!group.isOpen"
- class="fa fa-caret-right">
+ class="fa fa-caret-right"
+ aria-hidden="true"
+ >
</i>
</span>
<span class="folder-icon">
<i
v-if="group.isOpen"
class="fa fa-folder-open"
- aria-hidden="true">
+ aria-hidden="true"
+ >
</i>
<i
v-if="!group.isOpen"