diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2016-06-09 18:43:58 +0000 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2016-06-09 18:43:58 +0000 |
| commit | ae126c5599315b817a22e9d7b7866ea532c4d880 (patch) | |
| tree | 73bf8a7aeec388034d0162be7fce24b34f31cd9d | |
| parent | 8138f340f81d5144290893a7fc6897d9a502bbdb (diff) | |
| parent | 200bbbcb6a0d599b033f542c50182356a5eaa933 (diff) | |
| download | gitlab-ce-ae126c5599315b817a22e9d7b7866ea532c4d880.tar.gz | |
Merge branch '17562-filter-issues-is-only-visible-when-user-is-logged-in' into 'master'
#17562 Fixes issues list filter only visible when user is logged in
## What does this MR do?
1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field.
2. Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list.
## Are there points in the code the reviewer needs to double check?
Are there any views where the `margin-bottom: 12px` will affect the styling?
## Why was this MR needed?
Guest user UX. Nothing feels better than increasing intangible value!
## What are the relevant issue numbers?
Fixes #17562.
## Screenshots (if relevant)
/cc @jschatz1
**UPDATE:**
See merge request !4171
| -rw-r--r-- | CHANGELOG | 1 | ||||
| -rw-r--r-- | app/assets/stylesheets/framework/nav.scss | 13 | ||||
| -rw-r--r-- | app/views/projects/issues/index.html.haml | 2 |
3 files changed, 4 insertions, 12 deletions
diff --git a/CHANGELOG b/CHANGELOG index d81a31f8b40..17fc4801a6e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -179,6 +179,7 @@ v 8.8.0 - Fixed advice on invalid permissions on upload path !2948 (Ludovic Perrine) - Allows MR authors to have the source branch removed when merging the MR. !2801 (Jeroen Jacobs) - When creating a .gitignore file a dropdown with templates will be provided + - Shows the issue/MR list search/filter form and corrects the mobile styling for guest users. #17562 v 8.7.7 - Fix import by `Any Git URL` broken if the URL contains a space diff --git a/app/assets/stylesheets/framework/nav.scss b/app/assets/stylesheets/framework/nav.scss index 0918f673607..a036799e15a 100644 --- a/app/assets/stylesheets/framework/nav.scss +++ b/app/assets/stylesheets/framework/nav.scss @@ -171,6 +171,7 @@ > form { display: inline-block; margin-top: -1px; + margin-bottom: 12px; } .icon-label { @@ -207,7 +208,7 @@ @media (max-width: $screen-xs-max) { padding-bottom: 0; - + width: 100%; .btn, form, .dropdown, .dropdown-menu-toggle, .form-control { margin: 0 0 10px; display: block; @@ -238,16 +239,6 @@ margin: 0; } } - - /* Small devices (tablets, 768px and lower) */ - @media (max-width: $screen-sm-max) { - width: 100%; - text-align: left; - - input { - width: 300px; - } - } } } diff --git a/app/views/projects/issues/index.html.haml b/app/views/projects/issues/index.html.haml index 2a4027a6ecb..7c1457553d9 100644 --- a/app/views/projects/issues/index.html.haml +++ b/app/views/projects/issues/index.html.haml @@ -12,7 +12,7 @@ = icon('rss') %span.icon-label Subscribe - = render 'shared/issuable/search_form', path: namespace_project_issues_path(@project.namespace, @project) + = render 'shared/issuable/search_form', path: namespace_project_issues_path(@project.namespace, @project) - if can? current_user, :create_issue, @project = link_to new_namespace_project_issue_path(@project.namespace, @project, issue: { assignee_id: @issuable_finder.assignee.try(:id), milestone_id: @issuable_finder.milestones.try(:first).try(:id) }), class: "btn btn-new", title: "New Issue", id: "new_issue_link" do New Issue |