diff options
author | Gabriel Mazetto <gabriel@gitlab.com> | 2016-03-29 19:19:34 -0300 |
---|---|---|
committer | Gabriel Mazetto <gabriel@gitlab.com> | 2016-03-29 23:59:51 -0300 |
commit | a9b2a2744c93c848977a61ced56d66197027c0eb (patch) | |
tree | 966d16739655aef790dc2593ce21a6a4718b9a2f | |
parent | f7d20a6f76de33624f069185d28649e6e9b411f7 (diff) | |
download | gitlab-ce-a9b2a2744c93c848977a61ced56d66197027c0eb.tar.gz |
Use `diff_base_commit` instead of `target_branch` to generate diffs
-rw-r--r-- | app/controllers/projects/merge_requests_controller.rb | 4 | ||||
-rw-r--r-- | app/models/merge_request.rb | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/app/controllers/projects/merge_requests_controller.rb b/app/controllers/projects/merge_requests_controller.rb index 6189de09f27..785dcecc9be 100644 --- a/app/controllers/projects/merge_requests_controller.rb +++ b/app/controllers/projects/merge_requests_controller.rb @@ -57,8 +57,8 @@ class Projects::MergeRequestsController < Projects::ApplicationController respond_to do |format| format.html format.json { render json: @merge_request } - format.diff { render text: @merge_request.to_diff(current_user) } - format.patch { render text: @merge_request.to_patch(current_user) } + format.diff { render text: @merge_request.to_diff } + format.patch { render text: @merge_request.to_patch } end end diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index 7c61a7ae18c..b12a878327d 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -331,15 +331,15 @@ class MergeRequest < ActiveRecord::Base # Returns the raw diff for this merge request # # see "git diff" - def to_diff(current_user) - target_project.repository.diff_text(target_branch, source_sha) + def to_diff + target_project.repository.diff_text(diff_base_commit, source_sha) end # Returns the commit as a series of email patches. # # see "git format-patch" - def to_patch(current_user) - target_project.repository.format_patch(target_branch, source_sha) + def to_patch + target_project.repository.format_patch(diff_base_commit, source_sha) end def hook_attrs |