diff options
author | Drew Blessing <drew@blessing.io> | 2015-12-03 21:13:00 +0000 |
---|---|---|
committer | Drew Blessing <drew@blessing.io> | 2015-12-03 21:13:00 +0000 |
commit | 1481255efa653b036469a5c98fadd0ecdb46e5b0 (patch) | |
tree | 475ee5906272bc670d15b7cf6dfd0c90b86d417b | |
parent | abb7261889d002db6e2d80ee17ef034dd9f43a73 (diff) | |
parent | c5b6b31c847d5d2f467453d8292e13ca735ee630 (diff) | |
download | gitlab-ce-1481255efa653b036469a5c98fadd0ecdb46e5b0.tar.gz |
Merge branch 'issue_3468_broken_link' into 'master'
Fixed invalid link on starred projects dashboard.
Fixes #3468
The MR fixes 'Project' links on a dashboard pages headers. See the issue for the details.
This MR does not include tests since the change is rather trivial and there are no (as far as I have seen) existing tests for checking links validity.
In case tests are required I would like to get some guidance on the implementation first. At least I would like to know what should be covered: changed links, all header links, all navigation?
See merge request !1926
-rw-r--r-- | CHANGELOG | 1 | ||||
-rw-r--r-- | app/views/dashboard/projects/index.html.haml | 2 | ||||
-rw-r--r-- | app/views/dashboard/projects/starred.html.haml | 2 | ||||
-rw-r--r-- | app/views/explore/projects/index.html.haml | 2 | ||||
-rw-r--r-- | app/views/explore/projects/starred.html.haml | 2 | ||||
-rw-r--r-- | app/views/explore/projects/trending.html.haml | 2 |
6 files changed, 6 insertions, 5 deletions
diff --git a/CHANGELOG b/CHANGELOG index db812796b69..438cae617a7 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -13,6 +13,7 @@ v 8.2.2 - Fix Error 500 when viewing user's personal projects from admin page (Stan Hu) - Fix: Raw private snippets access workflow - Prevent "413 Request entity too large" errors when pushing large files with LFS + - Fix invalid links within projects dashboard header v 8.2.1 - Forcefully update builds that didn't want to update with state machine diff --git a/app/views/dashboard/projects/index.html.haml b/app/views/dashboard/projects/index.html.haml index 7a16b811f6b..53abf274bdb 100644 --- a/app/views/dashboard/projects/index.html.haml +++ b/app/views/dashboard/projects/index.html.haml @@ -3,7 +3,7 @@ = auto_discovery_link_tag(:atom, dashboard_projects_url(format: :atom, private_token: current_user.private_token), title: "All activity") - page_title "Projects" -- header_title "Projects", root_path +- header_title "Projects", dashboard_projects_path = render 'dashboard/projects_head' diff --git a/app/views/dashboard/projects/starred.html.haml b/app/views/dashboard/projects/starred.html.haml index f75f2e0a32a..70705923d42 100644 --- a/app/views/dashboard/projects/starred.html.haml +++ b/app/views/dashboard/projects/starred.html.haml @@ -1,5 +1,5 @@ - page_title "Starred Projects" -- header_title "Projects", projects_path +- header_title "Projects", dashboard_projects_path = render 'dashboard/projects_head' diff --git a/app/views/explore/projects/index.html.haml b/app/views/explore/projects/index.html.haml index 67e38ca3127..76bdd68fd76 100644 --- a/app/views/explore/projects/index.html.haml +++ b/app/views/explore/projects/index.html.haml @@ -1,5 +1,5 @@ - page_title "Projects" -- header_title "Projects", root_path +- header_title "Projects", dashboard_projects_path - if current_user = render 'dashboard/projects_head' diff --git a/app/views/explore/projects/starred.html.haml b/app/views/explore/projects/starred.html.haml index 596cb0a96cd..e30c3633223 100644 --- a/app/views/explore/projects/starred.html.haml +++ b/app/views/explore/projects/starred.html.haml @@ -1,5 +1,5 @@ - page_title "Projects" -- header_title "Projects", root_path +- header_title "Projects", dashboard_projects_path - if current_user = render 'dashboard/projects_head' diff --git a/app/views/explore/projects/trending.html.haml b/app/views/explore/projects/trending.html.haml index 5ea6d81c5b9..1412b19acde 100644 --- a/app/views/explore/projects/trending.html.haml +++ b/app/views/explore/projects/trending.html.haml @@ -1,5 +1,5 @@ - page_title "Projects" -- header_title "Projects", root_path +- header_title "Projects", dashboard_projects_path - if current_user = render 'dashboard/projects_head' |