diff options
| author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-11-14 17:53:56 +0000 |
|---|---|---|
| committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-11-14 17:53:56 +0000 |
| commit | 18f96e2612b47fbfa0ee9a84614c999b9d24ad54 (patch) | |
| tree | 7ffdbe6c05b94b5547eae534a5dcafa7df96b41c | |
| parent | 889dcf60d6714169301bc1314c7401df610a6203 (diff) | |
| parent | a2e67b7d06af6f03d5d65f54db49b2e9c474fc98 (diff) | |
| download | gitlab-ce-18f96e2612b47fbfa0ee9a84614c999b9d24ad54.tar.gz | |
Merge branch 'fix-search-input-padding' into 'master'
Give search-input correct padding-right value
## What does this MR do?
This fixes how `padding-right: 20px` was being applied to the style rule of `.search-input`, preventing text in that form from clipping through `.search-icon`
## Are there points in the code the reviewer needs to double check?
If there are any cases where `.search .search-input` is used in a search form where there is no right-side icon (I could not find such occurrence myself).
## Why was this MR needed?
Some text in long search queries were being hidden by the close icon being used in the search form. This makes it a bit more presentable. ;)
## Screenshots (if relevant)
__Before__
__After__
See merge request !7407
| -rw-r--r-- | app/assets/stylesheets/pages/search.scss | 3 | ||||
| -rw-r--r-- | changelogs/unreleased/fix-search-input-padding.yml | 4 |
2 files changed, 5 insertions, 2 deletions
diff --git a/app/assets/stylesheets/pages/search.scss b/app/assets/stylesheets/pages/search.scss index a0108bba6d9..1a116f6a919 100644 --- a/app/assets/stylesheets/pages/search.scss +++ b/app/assets/stylesheets/pages/search.scss @@ -33,10 +33,9 @@ } .search-input { - padding-right: 20px; border: none; font-size: 14px; - padding: 0; + padding: 0 20px 0 0; margin-left: 5px; line-height: 25px; width: 98%; diff --git a/changelogs/unreleased/fix-search-input-padding.yml b/changelogs/unreleased/fix-search-input-padding.yml new file mode 100644 index 00000000000..5d559d05d73 --- /dev/null +++ b/changelogs/unreleased/fix-search-input-padding.yml @@ -0,0 +1,4 @@ +--- +title: Give search-input correct padding-right value +merge_request: 7407 +author: Philip Karpiak |