summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-04-20 09:48:29 +0100
committerPhil Hughes <me@iamphill.com>2018-04-20 09:48:29 +0100
commit5ac76edb9879a56d064a976e4aba938669c8706b (patch)
treefff7186342d3cc2dd5a1c2c72c0a38abe47eade8
parent2e7389abc2bbbbb4058bfdd886d4a21f2dc5c426 (diff)
downloadgitlab-ce-5ac76edb9879a56d064a976e4aba938669c8706b.tar.gz
moved activity bar view constant into constants file
-rw-r--r--app/assets/javascripts/ide/components/activity_bar.vue2
-rw-r--r--app/assets/javascripts/ide/constants.js5
-rw-r--r--app/assets/javascripts/ide/stores/state.js5
-rw-r--r--spec/javascripts/ide/components/activity_bar_spec.js2
-rw-r--r--spec/javascripts/ide/components/ide_side_bar_spec.js2
5 files changed, 9 insertions, 7 deletions
diff --git a/app/assets/javascripts/ide/components/activity_bar.vue b/app/assets/javascripts/ide/components/activity_bar.vue
index 0bb191e2c0d..c625976621f 100644
--- a/app/assets/javascripts/ide/components/activity_bar.vue
+++ b/app/assets/javascripts/ide/components/activity_bar.vue
@@ -1,7 +1,7 @@
<script>
import { mapActions, mapGetters, mapState } from 'vuex';
import Icon from '~/vue_shared/components/icon.vue';
-import { ActivityBarViews } from '../stores/state';
+import { ActivityBarViews } from '../constants';
export default {
components: {
diff --git a/app/assets/javascripts/ide/constants.js b/app/assets/javascripts/ide/constants.js
index b60d042e0be..3aa32a49a20 100644
--- a/app/assets/javascripts/ide/constants.js
+++ b/app/assets/javascripts/ide/constants.js
@@ -1,3 +1,8 @@
// Fuzzy file finder
export const MAX_TITLE_LENGTH = 50;
export const MAX_BODY_LENGTH = 72;
+
+export const ActivityBarViews = {
+ edit: 'ide-tree',
+ commit: 'commit-section',
+};
diff --git a/app/assets/javascripts/ide/stores/state.js b/app/assets/javascripts/ide/stores/state.js
index c7f7e9562ac..5bf1afadb46 100644
--- a/app/assets/javascripts/ide/stores/state.js
+++ b/app/assets/javascripts/ide/stores/state.js
@@ -1,7 +1,4 @@
-export const ActivityBarViews = {
- edit: 'ide-tree',
- commit: 'commit-section',
-};
+import { ActivityBarViews } from '../constants';
export default () => ({
currentProjectId: '',
diff --git a/spec/javascripts/ide/components/activity_bar_spec.js b/spec/javascripts/ide/components/activity_bar_spec.js
index 67093081c05..5c7b4909fc7 100644
--- a/spec/javascripts/ide/components/activity_bar_spec.js
+++ b/spec/javascripts/ide/components/activity_bar_spec.js
@@ -1,6 +1,6 @@
import Vue from 'vue';
import store from '~/ide/stores';
-import { ActivityBarViews } from '~/ide/stores/state';
+import { ActivityBarViews } from '~/ide/constants';
import ActivityBar from '~/ide/components/activity_bar.vue';
import { createComponentWithStore } from '../../helpers/vue_mount_component_helper';
import { resetStore } from '../helpers';
diff --git a/spec/javascripts/ide/components/ide_side_bar_spec.js b/spec/javascripts/ide/components/ide_side_bar_spec.js
index 6286c82cca0..8784f2f965d 100644
--- a/spec/javascripts/ide/components/ide_side_bar_spec.js
+++ b/spec/javascripts/ide/components/ide_side_bar_spec.js
@@ -1,7 +1,7 @@
import Vue from 'vue';
import store from '~/ide/stores';
import ideSidebar from '~/ide/components/ide_side_bar.vue';
-import { ActivityBarViews } from '~/ide/stores/state';
+import { ActivityBarViews } from '~/ide/constants';
import { createComponentWithStore } from 'spec/helpers/vue_mount_component_helper';
import { resetStore } from '../helpers';
import { projectData } from '../mock_data';