diff options
| author | Winnie Hellmann <winnie@gitlab.com> | 2018-07-10 12:38:15 +0000 |
|---|---|---|
| committer | Winnie Hellmann <winnie@gitlab.com> | 2018-07-10 12:38:15 +0000 |
| commit | 191d8ecff6ece1a7f57b5d033cbe7405e4e06933 (patch) | |
| tree | 8aece9650c5041478c29073e110076610059631b | |
| parent | 6152d7a33e177f8b656f104a7e7d93c3a5562394 (diff) | |
| download | gitlab-ce-191d8ecff6ece1a7f57b5d033cbe7405e4e06933.tar.gz | |
Revert "Merge branch 'fix-inconsistent-cancel-button' into 'master'"
This reverts merge request !20140
| -rw-r--r-- | app/assets/javascripts/notes/components/note_form.vue | 2 | ||||
| -rw-r--r-- | app/views/shared/notes/_form.html.haml | 2 | ||||
| -rw-r--r-- | spec/features/projects/commit/comments/user_adds_comment_spec.rb | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/app/assets/javascripts/notes/components/note_form.vue b/app/assets/javascripts/notes/components/note_form.vue index 963e3a37b39..26482a02e00 100644 --- a/app/assets/javascripts/notes/components/note_form.vue +++ b/app/assets/javascripts/notes/components/note_form.vue @@ -200,7 +200,7 @@ js-autosize markdown-area js-vue-issue-note-form js-vue-textarea" class="btn btn-cancel note-edit-cancel js-close-discussion-note-form" type="button" @click="cancelHandler()"> - {{ __('Discard draft') }} + Cancel </button> </div> </form> diff --git a/app/views/shared/notes/_form.html.haml b/app/views/shared/notes/_form.html.haml index 6b2715b47a7..c360f1ffe2a 100644 --- a/app/views/shared/notes/_form.html.haml +++ b/app/views/shared/notes/_form.html.haml @@ -40,5 +40,5 @@ = yield(:note_actions) - %a.btn.btn-cancel.js-note-discard{ role: "button", data: {cancel_text: "Discard draft" } } + %a.btn.btn-cancel.js-note-discard{ role: "button", data: {cancel_text: "Cancel" } } Discard draft diff --git a/spec/features/projects/commit/comments/user_adds_comment_spec.rb b/spec/features/projects/commit/comments/user_adds_comment_spec.rb index 53866c32c69..6397df086a7 100644 --- a/spec/features/projects/commit/comments/user_adds_comment_spec.rb +++ b/spec/features/projects/commit/comments/user_adds_comment_spec.rb @@ -62,7 +62,7 @@ describe "User adds a comment on a commit", :js do click_diff_line(sample_commit.line_code) expect(page).to have_css(".js-temp-notes-holder form.new-note") - .and have_css(".js-close-discussion-note-form", text: "Discard draft") + .and have_css(".js-close-discussion-note-form", text: "Cancel") # The `Cancel` button closes the current form. The page should not have any open forms after that. find(".js-close-discussion-note-form").click |