summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-04-20 08:39:41 +0100
committerPhil Hughes <me@iamphill.com>2018-04-20 08:39:41 +0100
commit5711296bfd57505987302f0344cc5e11368a9f6d (patch)
treefcabcc32e0a805d9209efde5b668b8f853bcd572
parent913c607030a32742fcd6e72cfe0557b329583173 (diff)
downloadgitlab-ce-5711296bfd57505987302f0344cc5e11368a9f6d.tar.gz
remove need for getter, allow state to set component
-rw-r--r--app/assets/javascripts/ide/components/ide_side_bar.vue6
-rw-r--r--app/assets/javascripts/ide/stores/getters.js11
-rw-r--r--app/assets/javascripts/ide/stores/state.js4
3 files changed, 5 insertions, 16 deletions
diff --git a/app/assets/javascripts/ide/components/ide_side_bar.vue b/app/assets/javascripts/ide/components/ide_side_bar.vue
index 21074e933c0..191210fd828 100644
--- a/app/assets/javascripts/ide/components/ide_side_bar.vue
+++ b/app/assets/javascripts/ide/components/ide_side_bar.vue
@@ -23,8 +23,8 @@ export default {
IdeTree,
},
computed: {
- ...mapState(['loading', 'currentBranchId']),
- ...mapGetters(['currentProject', 'activityBarComponent']),
+ ...mapState(['loading', 'currentBranchId', 'currentActivityView']),
+ ...mapGetters(['currentProject']),
},
};
</script>
@@ -88,7 +88,7 @@ export default {
</div>
<div class="multi-file-commit-panel-inner-scroll">
<component
- :is="activityBarComponent"
+ :is="currentActivityView"
/>
</div>
</template>
diff --git a/app/assets/javascripts/ide/stores/getters.js b/app/assets/javascripts/ide/stores/getters.js
index 69cf5a5fc95..cdaa5e05c18 100644
--- a/app/assets/javascripts/ide/stores/getters.js
+++ b/app/assets/javascripts/ide/stores/getters.js
@@ -39,15 +39,4 @@ export const hasChanges = state => !!state.changedFiles.length || !!state.staged
export const hasMergeRequest = state => !!state.currentMergeRequestId;
-export const activityBarComponent = state => {
- switch (state.currentActivityView) {
- case ActivityBarViews.edit:
- return 'ide-tree';
- case ActivityBarViews.commit:
- return 'commit-section';
- default:
- return null;
- }
-};
-
export const getStagedFile = state => path => state.stagedFiles.find(f => f.path === path);
diff --git a/app/assets/javascripts/ide/stores/state.js b/app/assets/javascripts/ide/stores/state.js
index 2beefce32ac..c7f7e9562ac 100644
--- a/app/assets/javascripts/ide/stores/state.js
+++ b/app/assets/javascripts/ide/stores/state.js
@@ -1,6 +1,6 @@
export const ActivityBarViews = {
- edit: 0,
- commit: 1,
+ edit: 'ide-tree',
+ commit: 'commit-section',
};
export default () => ({