summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean McGivern <sean@mcgivern.me.uk>2017-11-21 12:28:03 +0000
committerSean McGivern <sean@mcgivern.me.uk>2017-11-21 12:28:03 +0000
commit6dd89059b8d4ed412313067aab44a1969558b687 (patch)
treefcab0f4cbbd28f6834b9eb6da208b71bb0ae4341
parent15cb13ee87939a339631c217fcf42223af51b31e (diff)
parent6f1e9f7ef773ead892a1d43ec15a38dfb486e229 (diff)
downloadgitlab-ce-6dd89059b8d4ed412313067aab44a1969558b687.tar.gz
Merge branch 'gitaly-test-no-deployment' into 'master'
Fix slow gitaly dev test bundle See merge request gitlab-org/gitlab-ce!15508
-rw-r--r--lib/tasks/gitlab/gitaly.rake4
-rw-r--r--spec/tasks/gitlab/gitaly_rake_spec.rb4
2 files changed, 3 insertions, 5 deletions
diff --git a/lib/tasks/gitlab/gitaly.rake b/lib/tasks/gitlab/gitaly.rake
index 8377fe3269d..87835dbe719 100644
--- a/lib/tasks/gitlab/gitaly.rake
+++ b/lib/tasks/gitlab/gitaly.rake
@@ -17,9 +17,7 @@ namespace :gitlab do
_, status = Gitlab::Popen.popen(%w[which gmake])
command = status.zero? ? ['gmake'] : ['make']
- if Rails.env.test?
- command += %W[BUNDLE_PATH=#{Bundler.bundle_path}]
- end
+ command << 'BUNDLE_FLAGS=--no-deployment' if Rails.env.test?
Dir.chdir(args.dir) do
create_gitaly_configuration
diff --git a/spec/tasks/gitlab/gitaly_rake_spec.rb b/spec/tasks/gitlab/gitaly_rake_spec.rb
index 5dd8fe8eaa5..255f0a37ec8 100644
--- a/spec/tasks/gitlab/gitaly_rake_spec.rb
+++ b/spec/tasks/gitlab/gitaly_rake_spec.rb
@@ -57,7 +57,7 @@ describe 'gitlab:gitaly namespace rake task' do
it 'calls gmake in the gitaly directory' do
expect(Gitlab::Popen).to receive(:popen).with(%w[which gmake]).and_return(['/usr/bin/gmake', 0])
- expect(main_object).to receive(:run_command!).with(command_preamble + %w[gmake BUNDLE_PATH=/fake/bundle_path]).and_return(true)
+ expect(main_object).to receive(:run_command!).with(command_preamble + %w[gmake BUNDLE_FLAGS=--no-deployment]).and_return(true)
run_rake_task('gitlab:gitaly:install', clone_path)
end
@@ -70,7 +70,7 @@ describe 'gitlab:gitaly namespace rake task' do
end
it 'calls make in the gitaly directory' do
- expect(main_object).to receive(:run_command!).with(command_preamble + %w[make BUNDLE_PATH=/fake/bundle_path]).and_return(true)
+ expect(main_object).to receive(:run_command!).with(command_preamble + %w[make BUNDLE_FLAGS=--no-deployment]).and_return(true)
run_rake_task('gitlab:gitaly:install', clone_path)
end