Moved LfsIntegrity specs to own file

2 files changed, 59 insertions, 37 deletions

diff --git a/spec/lib/gitlab/checks/change_access_spec.rb b/spec/lib/gitlab/checks/change_access_spec.rb
index 74a24a4424b..c2bca816aae 100644
--- a/spec/lib/gitlab/checks/change_access_spec.rb
+++ b/spec/lib/gitlab/checks/change_access_spec.rb
@@ -165,47 +165,16 @@ describe Gitlab::Checks::ChangeAccess do
     end
 
     context 'LFS integrity check' do
-      let(:blob_object) { project.repository.blob_at_branch('lfs', 'files/lfs/lfs_object.iso') }
+      it 'fails if any LFS blobs are missing' do
+        allow_any_instance_of(Gitlab::Checks::LfsIntegrity).to receive(:objects_missing?).and_return(true)
 
-      before do
-        allow_any_instance_of(Gitlab::Git::RevList).to receive(:new_objects) do |&lazy_block|
-          lazy_block.call([blob_object.id])
-        end
-      end
-
-      context 'with LFS not enabled' do
-        it 'skips integrity check' do
-          expect_any_instance_of(Gitlab::Git::RevList).not_to receive(:new_objects)
-
-          subject.exec
-        end
+        expect { subject.exec }.to raise_error(Gitlab::GitAccess::UnauthorizedError, /LFS objects are missing/)
       end
 
-      context 'with LFS enabled' do
-        before do
-          allow(project).to receive(:lfs_enabled?).and_return(true)
-        end
-
-        context 'deletion' do
-          let(:changes) { { oldrev: oldrev, ref: ref } }
-
-          it 'skips integrity check' do
-            expect_any_instance_of(Gitlab::Git::RevList).not_to receive(:new_objects)
+      it 'succeeds if LFS objects have already been uploaded' do
+        allow_any_instance_of(Gitlab::Checks::LfsIntegrity).to receive(:objects_missing?).and_return(false)
 
-            subject.exec
-          end
-        end
-
-        it 'fails if any LFS blobs are missing' do
-          expect { subject.exec }.to raise_error(Gitlab::GitAccess::UnauthorizedError, /LFS objects are missing/)
-        end
-
-        it 'succeeds if LFS objects have already been uploaded' do
-          lfs_object = create(:lfs_object, oid: blob_object.lfs_oid)
-          create(:lfs_objects_project, project: project, lfs_object: lfs_object)
-
-          expect { subject.exec }.not_to raise_error
-        end
+        expect { subject.exec }.not_to raise_error
       end
     end
   end
diff --git a/spec/lib/gitlab/checks/lfs_integrity_spec.rb b/spec/lib/gitlab/checks/lfs_integrity_spec.rb
new file mode 100644
index 00000000000..5e682907fc6
--- /dev/null
+++ b/spec/lib/gitlab/checks/lfs_integrity_spec.rb
@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Gitlab::Checks::LfsIntegrity do
+  let(:project) { create(:project, :repository) }
+  let(:newrev) { '54fcc214b94e78d7a41a9a8fe6d87a5e59500e51' }
+
+  subject { described_class.new(project, newrev) }
+
+  describe '#objects_missing?' do
+    let(:blob_object) { project.repository.blob_at_branch('lfs', 'files/lfs/lfs_object.iso') }
+
+    before do
+      allow_any_instance_of(Gitlab::Git::RevList).to receive(:new_objects) do |&lazy_block|
+        lazy_block.call([blob_object.id])
+      end
+    end
+
+    context 'with LFS not enabled' do
+      it 'skips integrity check' do
+        expect_any_instance_of(Gitlab::Git::RevList).not_to receive(:new_objects)
+
+        subject.objects_missing?
+      end
+    end
+
+    context 'with LFS enabled' do
+      before do
+        allow(project).to receive(:lfs_enabled?).and_return(true)
+      end
+
+      context 'deletion' do
+        let(:newrev) { nil }
+
+        it 'skips integrity check' do
+          expect_any_instance_of(Gitlab::Git::RevList).not_to receive(:new_objects)
+
+          expect(subject.objects_missing?).to be_falsey
+        end
+      end
+
+      it 'is true if any LFS blobs are missing' do
+        expect(subject.objects_missing?).to be_truthy
+      end
+
+      it 'is false if LFS objects have already been uploaded' do
+        lfs_object = create(:lfs_object, oid: blob_object.lfs_oid)
+        create(:lfs_objects_project, project: project, lfs_object: lfs_object)
+
+        expect(subject.objects_missing?).to be_falsey
+      end
+    end
+  end
+end