summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortiagonbotelho <tiagonbotelho@hotmail.com>2016-11-23 13:37:42 +0000
committertiagonbotelho <tiagonbotelho@hotmail.com>2016-11-24 12:00:29 +0000
commit2f5637d6e39efa4b1a1cd2acdffa478e903ecd98 (patch)
tree4b6e1d7f3a1aa6dbc8c8d5ee713860f345744227
parent02c6cbf53f4799bc888db7767c2d9a5e04a30002 (diff)
downloadgitlab-ce-2f5637d6e39efa4b1a1cd2acdffa478e903ecd98.tar.gz
renames some of the specs and adds changelog entry24779-last-deployment-call-on-nil-environment-fix
-rw-r--r--changelogs/unreleased/24779-last-deployment-call-on-nil-environment-fix.yml4
-rw-r--r--spec/views/projects/builds/show.html.haml_spec.rb6
2 files changed, 7 insertions, 3 deletions
diff --git a/changelogs/unreleased/24779-last-deployment-call-on-nil-environment-fix.yml b/changelogs/unreleased/24779-last-deployment-call-on-nil-environment-fix.yml
new file mode 100644
index 00000000000..5e7580fb8f2
--- /dev/null
+++ b/changelogs/unreleased/24779-last-deployment-call-on-nil-environment-fix.yml
@@ -0,0 +1,4 @@
+---
+title: fixes last_deployment call environment is nil
+merge_request: 7671
+author:
diff --git a/spec/views/projects/builds/show.html.haml_spec.rb b/spec/views/projects/builds/show.html.haml_spec.rb
index 869dcb417e6..745d0c745bd 100644
--- a/spec/views/projects/builds/show.html.haml_spec.rb
+++ b/spec/views/projects/builds/show.html.haml_spec.rb
@@ -88,7 +88,7 @@ describe 'projects/builds/show', :view do
create(:ci_build, :running, environment: 'staging', pipeline: pipeline)
end
- context 'and environment does exist' do
+ context 'when environment exists' do
let!(:environment) do
create(:environment, name: 'staging', project: project)
end
@@ -101,7 +101,7 @@ describe 'projects/builds/show', :view do
'.environment-information', text: expected_text)
end
- context 'and has deployment' do
+ context 'when it has deployment' do
let!(:deployment) do
create(:deployment, environment: environment)
end
@@ -118,7 +118,7 @@ describe 'projects/builds/show', :view do
end
end
- context 'and environment does not exist' do
+ context 'when environment does not exist' do
it 'shows deployment message' do
expected_text = 'This build is creating a deployment to staging'
render