diff options
author | Stan Hu <stanhu@gmail.com> | 2016-06-08 13:30:19 +0000 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2016-06-08 13:30:19 +0000 |
commit | 8d6c4b307c2c0ecffc57aaf4ebd0e5a23eae0a66 (patch) | |
tree | 98c996cbe7d8cecb54053ba044e4bd8ba15031be | |
parent | 53bf9da4b4a99b2801633efebf5ec07a720e41f7 (diff) | |
parent | 76d618404ee8a47a34b45dfe41d268eaaf52f00d (diff) | |
download | gitlab-ce-8d6c4b307c2c0ecffc57aaf4ebd0e5a23eae0a66.tar.gz |
Merge branch 'fix-markdown-spec' into 'master'
Fix markdown_spec to not use `before(:all)` in order to properly cleanup database after testing
See merge request !4515
-rw-r--r-- | CHANGELOG | 1 | ||||
-rw-r--r-- | spec/features/markdown_spec.rb | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/CHANGELOG b/CHANGELOG index 59c71699421..6b12e31bbb4 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -40,6 +40,7 @@ v 8.9.0 (unreleased) - Cache assigned issue and merge request counts in sidebar nav - Use Knapsack only in CI environment - Cache project build count in sidebar nav + - Fix markdown_spec to use before instead of before(:all) to properly cleanup database after testing - Reduce number of queries needed to render issue labels in the sidebar - Improve error handling importing projects - Remove duplicated notification settings diff --git a/spec/features/markdown_spec.rb b/spec/features/markdown_spec.rb index 1d892fe1a55..7663d193354 100644 --- a/spec/features/markdown_spec.rb +++ b/spec/features/markdown_spec.rb @@ -180,7 +180,7 @@ describe 'GitLab Markdown', feature: true do end end - before(:all) do + before do @feat = MarkdownFeature.new # `markdown` helper expects a `@project` variable @@ -188,7 +188,7 @@ describe 'GitLab Markdown', feature: true do end context 'default pipeline' do - before(:all) do + before do @html = markdown(@feat.raw_markdown) end |