diff options
| author | Lin Jen-Shin <godfat@godfat.org> | 2016-08-12 15:33:28 +0800 |
|---|---|---|
| committer | Lin Jen-Shin <godfat@godfat.org> | 2016-08-12 15:33:28 +0800 |
| commit | 0a20897bbee538761352595e8f632c747b6d1b35 (patch) | |
| tree | cad49d9f4b74a3644cf4e30db512c170e40dc50b | |
| parent | abd3ac4a038a83cce5db2aa93f685c921710abba (diff) | |
| download | gitlab-ce-0a20897bbee538761352595e8f632c747b6d1b35.tar.gz | |
Prefer extend self over module_function, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13672004
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13810498
| -rw-r--r-- | lib/gitlab/data_builder/build_data_builder.rb | 2 | ||||
| -rw-r--r-- | lib/gitlab/data_builder/note_data_builder.rb | 2 | ||||
| -rw-r--r-- | lib/gitlab/data_builder/pipeline_data_builder.rb | 2 | ||||
| -rw-r--r-- | lib/gitlab/data_builder/push_data_builder.rb | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/lib/gitlab/data_builder/build_data_builder.rb b/lib/gitlab/data_builder/build_data_builder.rb index 5175645e238..1b42769bf5b 100644 --- a/lib/gitlab/data_builder/build_data_builder.rb +++ b/lib/gitlab/data_builder/build_data_builder.rb @@ -1,7 +1,7 @@ module Gitlab module DataBuilder module BuildDataBuilder - module_function + extend self def build(build) project = build.project diff --git a/lib/gitlab/data_builder/note_data_builder.rb b/lib/gitlab/data_builder/note_data_builder.rb index 12ae1b99f9c..78dc583abc7 100644 --- a/lib/gitlab/data_builder/note_data_builder.rb +++ b/lib/gitlab/data_builder/note_data_builder.rb @@ -1,7 +1,7 @@ module Gitlab module DataBuilder module NoteDataBuilder - module_function + extend self # Produce a hash of post-receive data # diff --git a/lib/gitlab/data_builder/pipeline_data_builder.rb b/lib/gitlab/data_builder/pipeline_data_builder.rb index 3dc4d50fcde..1cba74c7065 100644 --- a/lib/gitlab/data_builder/pipeline_data_builder.rb +++ b/lib/gitlab/data_builder/pipeline_data_builder.rb @@ -1,7 +1,7 @@ module Gitlab module DataBuilder module PipelineDataBuilder - module_function + extend self def build(pipeline) { diff --git a/lib/gitlab/data_builder/push_data_builder.rb b/lib/gitlab/data_builder/push_data_builder.rb index f0cad51dd36..f0debe7b19f 100644 --- a/lib/gitlab/data_builder/push_data_builder.rb +++ b/lib/gitlab/data_builder/push_data_builder.rb @@ -1,7 +1,7 @@ module Gitlab module DataBuilder module PushDataBuilder - module_function + extend self # Produce a hash of post-receive data # |