diff options
author | Michael Kozono <mkozono@gmail.com> | 2018-06-08 10:00:03 -0700 |
---|---|---|
committer | Michael Kozono <mkozono@gmail.com> | 2018-06-12 13:58:02 -0700 |
commit | 3c05964b51d29ac15ffbeaedacae762d512996fc (patch) | |
tree | 8553648969df608b8fd05d6399e67cfae0cfacbd | |
parent | 9b43dc8395fe2634ecae47750cdea1d51b9c61a3 (diff) | |
download | gitlab-ce-3c05964b51d29ac15ffbeaedacae762d512996fc.tar.gz |
Refactor for readability
-rw-r--r-- | lib/gitlab/verify/batch_verifier.rb | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/lib/gitlab/verify/batch_verifier.rb b/lib/gitlab/verify/batch_verifier.rb index a1e9f0f5540..9d50f573b24 100644 --- a/lib/gitlab/verify/batch_verifier.rb +++ b/lib/gitlab/verify/batch_verifier.rb @@ -15,7 +15,7 @@ module Gitlab def run_batches(&blk) all_relation.in_batches(of: batch_size, start: start, finish: finish) do |all_relation| # rubocop: disable Cop/InBatches range = all_relation.first.id..all_relation.last.id - failures = run_batch(all_relation) + failures = run_batch_for(all_relation) yield(range, failures) end @@ -31,16 +31,12 @@ module Gitlab private - def run_batch(all_relation) + def run_batch_for(all_relation) all_relation.map { |upload| verify(upload) }.compact.to_h end def verify(object) - if local?(object) - verify_local(object) - else - verify_remote(object) - end + local?(object) ? verify_local(object) : verify_remote(object) nil rescue => err |