summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2018-06-08 10:55:48 +0000
committerDouwe Maan <douwe@gitlab.com>2018-06-08 10:55:48 +0000
commit8a7d01ebac078d47b53d705dceba47e308f1347a (patch)
tree1039090a57ee8c0781f6aa8fef920c030a53c650
parentb085edeeaaa121136e63be009cb45474b941ff88 (diff)
parent2120391441848a41c477e44d72fa5f3abc2bbafd (diff)
downloadgitlab-ce-8a7d01ebac078d47b53d705dceba47e308f1347a.tar.gz
Merge branch 'lib-gitlab-git-version-popen' into 'master'
Remove Gitlab::Popen dependency from lib/gitlab/git See merge request gitlab-org/gitlab-ce!19577
-rw-r--r--lib/gitlab/git.rb2
-rw-r--r--lib/gitlab/git/version.rb11
2 files changed, 12 insertions, 1 deletions
diff --git a/lib/gitlab/git.rb b/lib/gitlab/git.rb
index e85e87a54af..55236a1122f 100644
--- a/lib/gitlab/git.rb
+++ b/lib/gitlab/git.rb
@@ -62,7 +62,7 @@ module Gitlab
end
def version
- Gitlab::VersionInfo.parse(Gitlab::Popen.popen(%W(#{Gitlab.config.git.bin_path} --version)).first)
+ Gitlab::Git::Version.git_version
end
def check_namespace!(*objects)
diff --git a/lib/gitlab/git/version.rb b/lib/gitlab/git/version.rb
new file mode 100644
index 00000000000..11184ca3457
--- /dev/null
+++ b/lib/gitlab/git/version.rb
@@ -0,0 +1,11 @@
+module Gitlab
+ module Git
+ module Version
+ extend Gitlab::Git::Popen
+
+ def self.git_version
+ Gitlab::VersionInfo.parse(popen(%W(#{Gitlab.config.git.bin_path} --version), nil).first)
+ end
+ end
+ end
+end