diff options
author | Rémy Coutable <remy@rymai.me> | 2018-07-16 08:57:23 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-07-16 08:57:23 +0000 |
commit | 25af7197ba7357c5a3ca5a0052472a74490e6c63 (patch) | |
tree | 78ede8181ef2fc244d1df49a72df6fac55982b31 | |
parent | 62563a393fb9402b441666b5b047cbd3c80bcc6b (diff) | |
parent | 829b20010d0ded17a84355c44047114327248818 (diff) | |
download | gitlab-ce-25af7197ba7357c5a3ca5a0052472a74490e6c63.tar.gz |
Merge branch 'mk/fix-flaky-protected-branch-expectations' into 'master'
QA: Remove flaky and redundant expectations
Closes #49164
See merge request gitlab-org/gitlab-ce!20616
5 files changed, 3 insertions, 44 deletions
diff --git a/app/views/projects/protected_branches/_update_protected_branch.html.haml b/app/views/projects/protected_branches/_update_protected_branch.html.haml index f242459f69b..74bfaa9ff80 100644 --- a/app/views/projects/protected_branches/_update_protected_branch.html.haml +++ b/app/views/projects/protected_branches/_update_protected_branch.html.haml @@ -6,5 +6,5 @@ %td = hidden_field_tag "allowed_to_push_#{protected_branch.id}", protected_branch.push_access_levels.first.access_level = dropdown_tag( (protected_branch.push_access_levels.first.humanize || 'Select') , - options: { toggle_class: 'js-allowed-to-push qa-allowed-to-push', dropdown_class: 'dropdown-menu-selectable js-allowed-to-push-container capitalize-header', + options: { toggle_class: 'js-allowed-to-push', dropdown_class: 'dropdown-menu-selectable js-allowed-to-push-container capitalize-header', data: { field_name: "allowed_to_push_#{protected_branch.id}", access_level_id: protected_branch.push_access_levels.first.id }}) diff --git a/app/views/projects/protected_branches/shared/_protected_branch.html.haml b/app/views/projects/protected_branches/shared/_protected_branch.html.haml index 82ef08272d3..05cee483c0e 100644 --- a/app/views/projects/protected_branches/shared/_protected_branch.html.haml +++ b/app/views/projects/protected_branches/shared/_protected_branch.html.haml @@ -2,7 +2,7 @@ %tr.js-protected-branch-edit-form{ data: { url: namespace_project_protected_branch_path(@project.namespace, @project, protected_branch) } } %td - %span.ref-name.qa-protected-branch-name= protected_branch.name + %span.ref-name= protected_branch.name - if @project.root_ref?(protected_branch.name) %span.badge.badge-info.prepend-left-5 default diff --git a/qa/qa/factory/resource/branch.rb b/qa/qa/factory/resource/branch.rb index 7fb0633ec90..bc252bf3148 100644 --- a/qa/qa/factory/resource/branch.rb +++ b/qa/qa/factory/resource/branch.rb @@ -9,18 +9,6 @@ module QA project.name = 'protected-branch-project' end - product :name do - Page::Project::Settings::Repository.act do - expand_protected_branches(&:last_branch_name) - end - end - - product :push_allowance do - Page::Project::Settings::Repository.act do - expand_protected_branches(&:last_push_allowance) - end - end - def initialize @branch_name = 'test/branch' @allow_to_push = true @@ -80,15 +68,6 @@ module QA end page.protect_branch - - # Avoid Selenium::WebDriver::Error::StaleElementReferenceError - # without sleeping. I.e. this completes fast on fast machines. - page.refresh - - # It is possible for the protected branch row to "disappear" at first - page.wait do - page.has_content?(branch_name) - end end end end diff --git a/qa/qa/page/project/settings/protected_branches.rb b/qa/qa/page/project/settings/protected_branches.rb index e572ae12132..76591a4e3fe 100644 --- a/qa/qa/page/project/settings/protected_branches.rb +++ b/qa/qa/page/project/settings/protected_branches.rb @@ -16,7 +16,6 @@ module QA end view 'app/views/projects/protected_branches/_update_protected_branch.html.haml' do - element :allowed_to_push element :allowed_to_merge end @@ -24,10 +23,6 @@ module QA element :protected_branches_list end - view 'app/views/projects/protected_branches/shared/_protected_branch.html.haml' do - element :protected_branch_name - end - def select_branch(branch_name) click_element :protected_branch_select @@ -62,18 +57,6 @@ module QA click_on 'Protect' end - def last_branch_name - within_element(:protected_branches_list) do - all('.qa-protected-branch-name').last - end - end - - def last_push_allowance - within_element(:protected_branches_list) do - all('.qa-allowed-to-push').last - end - end - private def click_allow(action, text) diff --git a/qa/qa/specs/features/repository/protected_branches_spec.rb b/qa/qa/specs/features/repository/protected_branches_spec.rb index 4e593a69aae..c2de94516d9 100644 --- a/qa/qa/specs/features/repository/protected_branches_spec.rb +++ b/qa/qa/specs/features/repository/protected_branches_spec.rb @@ -21,11 +21,8 @@ module QA end context 'when developers and maintainers are allowed to push to a protected branch' do - let!(:protected_branch) { create_protected_branch(allow_to_push: true) } - it 'user with push rights successfully pushes to the protected branch' do - expect(protected_branch.name).to have_content(branch_name) - expect(protected_branch.push_allowance).to have_content('Developers + Maintainers') + create_protected_branch(allow_to_push: true) push = push_new_file(branch_name) |