summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-07-31 12:23:04 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-07-31 12:23:04 +0200
commit13a15e7009e292919109ea911640a627dbd0e327 (patch)
tree9fbb761ee28a2bd9c6907d99ecc0809da8a4bf9a
parentcec2cc3ffa3077346c81625f6b1f48c113e19e93 (diff)
downloadgitlab-ce-13a15e7009e292919109ea911640a627dbd0e327.tar.gz
Use update_column_in_batches helper in stages migration
-rw-r--r--app/models/ci/stage.rb2
-rw-r--r--db/post_migrate/20170711145558_migrate_stages_statuses.rb4
2 files changed, 1 insertions, 5 deletions
diff --git a/app/models/ci/stage.rb b/app/models/ci/stage.rb
index cd2f1dd3509..7819bc3cd2c 100644
--- a/app/models/ci/stage.rb
+++ b/app/models/ci/stage.rb
@@ -17,8 +17,6 @@ module Ci
validates :pipeline, presence: true, unless: :importing?
validates :name, presence: true, unless: :importing?
- ## TODO, should we extract these events to `Ci::Eventable`?
- #
state_machine :status, initial: :created do
event :enqueue do
transition created: :pending
diff --git a/db/post_migrate/20170711145558_migrate_stages_statuses.rb b/db/post_migrate/20170711145558_migrate_stages_statuses.rb
index 1641e550480..5a24fb1307f 100644
--- a/db/post_migrate/20170711145558_migrate_stages_statuses.rb
+++ b/db/post_migrate/20170711145558_migrate_stages_statuses.rb
@@ -28,8 +28,6 @@ class MigrateStagesStatuses < ActiveRecord::Migration
def down
disable_statement_timeout
- execute <<-SQL.strip_heredoc
- UPDATE ci_stages SET status = null
- SQL
+ update_column_in_batches(:ci_stages, :status, nil)
end
end