summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Schatz <jschatz@gitlab.com>2017-01-21 19:58:41 +0000
committerJacob Schatz <jschatz@gitlab.com>2017-01-21 19:58:41 +0000
commit85a3c03c6889b7c9f4afd695a0e91b4c41759a69 (patch)
tree612145cb77b6166d468ec9aff12b957b6bac6fd0
parent1fce08f9769df0644cf7c6049d631a01445bb029 (diff)
downloadgitlab-ce-85a3c03c6889b7c9f4afd695a0e91b4c41759a69.tar.gz
Revert "Merge branch '25709-diff-file-overflow' into 'master'"
This reverts merge request !8475
-rw-r--r--app/assets/stylesheets/framework/files.scss34
-rw-r--r--app/assets/stylesheets/pages/diff.scss4
-rw-r--r--app/views/projects/diffs/_file.html.haml2
-rw-r--r--app/views/projects/diffs/_file_header.html.haml6
-rw-r--r--changelogs/unreleased/25709-diff-file-overflow.yml4
5 files changed, 4 insertions, 46 deletions
diff --git a/app/assets/stylesheets/framework/files.scss b/app/assets/stylesheets/framework/files.scss
index db1c8da06d0..c51912b4ac4 100644
--- a/app/assets/stylesheets/framework/files.scss
+++ b/app/assets/stylesheets/framework/files.scss
@@ -231,37 +231,3 @@ span.idiff {
}
}
}
-
-
-.file-title-flex-parent {
- display: flex;
- align-items: center;
- background-color: $gray-light;
- border-bottom: 1px solid $border-color;
- padding: 10px $gl-padding;
- margin: 0;
- border-radius: 3px 3px 0 0;
-
- > a {
- flex: 1;
- white-space: nowrap;
- overflow: hidden;
- text-overflow: ellipsis;
- color: $gl-text-color;
- }
-
- small {
- margin: 0 10px 0 0;
- }
-
- .file-actions {
- white-space: nowrap;
-
- .btn {
- padding: 0 10px;
- font-size: 13px;
- line-height: 28px;
- display: inline-block;
- }
- }
-}
diff --git a/app/assets/stylesheets/pages/diff.scss b/app/assets/stylesheets/pages/diff.scss
index 8b784c2a439..96ba7c40634 100644
--- a/app/assets/stylesheets/pages/diff.scss
+++ b/app/assets/stylesheets/pages/diff.scss
@@ -37,10 +37,6 @@
.file-title {
cursor: pointer;
- a:hover {
- text-decoration: none;
- }
-
&:hover {
background-color: $gray-normal;
}
diff --git a/app/views/projects/diffs/_file.html.haml b/app/views/projects/diffs/_file.html.haml
index 7ab2eb1bce9..c37a33bbcd5 100644
--- a/app/views/projects/diffs/_file.html.haml
+++ b/app/views/projects/diffs/_file.html.haml
@@ -1,5 +1,5 @@
.diff-file.file-holder{ id: file_hash, data: diff_file_html_data(project, diff_file.file_path, diff_commit.id) }
- .file-title-flex-parent
+ .file-title
= render "projects/diffs/file_header", diff_file: diff_file, blob: blob, diff_commit: diff_commit, project: project, url: "##{file_hash}"
- unless diff_file.submodule?
diff --git a/app/views/projects/diffs/_file_header.html.haml b/app/views/projects/diffs/_file_header.html.haml
index 1e5ac4ed38c..90c9a0c6c2b 100644
--- a/app/views/projects/diffs/_file_header.html.haml
+++ b/app/views/projects/diffs/_file_header.html.haml
@@ -10,13 +10,13 @@
- if diff_file.renamed_file
- old_path, new_path = mark_inline_diffs(diff_file.old_path, diff_file.new_path)
- %strong.file-title-name.has-tooltip{ data: { title: old_path } }
+ %strong
= old_path
&rarr;
- %strong.file-title-name.has-tooltip{ data: { title: new_path } }
+ %strong
= new_path
- else
- %strong.file-title-name.has-tooltip{ data: { title: diff_file.new_path } }
+ %strong
= diff_file.new_path
- if diff_file.deleted_file
deleted
diff --git a/changelogs/unreleased/25709-diff-file-overflow.yml b/changelogs/unreleased/25709-diff-file-overflow.yml
deleted file mode 100644
index 7d1b2b36ab8..00000000000
--- a/changelogs/unreleased/25709-diff-file-overflow.yml
+++ /dev/null
@@ -1,4 +0,0 @@
----
-title: Responsive title in diffs inline, side by side, with and without sidebar
-merge_request: 8475
-author: