summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLong Nguyen <long.polyglot@gmail.com>2016-04-26 23:20:19 +0700
committerLong Nguyen <long.polyglot@gmail.com>2016-04-26 23:20:19 +0700
commit247ae960552acc8cd3be299dbb10ed61d8dafe75 (patch)
tree60bbeaa2355e67a63fbed2575064e4ac481a3f4b
parentdf8fda60fbbd2b6b38bdcb1680a0f24598c29f79 (diff)
downloadgitlab-ce-247ae960552acc8cd3be299dbb10ed61d8dafe75.tar.gz
Allow to assign labels and milestone to target project when moving issue
-rw-r--r--app/services/issues/move_service.rb11
-rw-r--r--spec/services/issues/move_service_spec.rb20
2 files changed, 30 insertions, 1 deletions
diff --git a/app/services/issues/move_service.rb b/app/services/issues/move_service.rb
index 82e7090f1ea..8d41ea5df55 100644
--- a/app/services/issues/move_service.rb
+++ b/app/services/issues/move_service.rb
@@ -41,7 +41,8 @@ module Issues
private
def create_new_issue
- new_params = { id: nil, iid: nil, label_ids: [], milestone: nil,
+ new_params = { id: nil, iid: nil, label_ids: cloneable_label_ids,
+ milestone: cloneable_milestone_id,
project: @new_project, author: @old_issue.author,
description: rewrite_content(@old_issue.description) }
@@ -49,6 +50,14 @@ module Issues
CreateService.new(@new_project, @current_user, new_params).execute
end
+ def cloneable_label_ids
+ @new_project.labels.where(title: @old_issue.labels.pluck(:title)).pluck(:id)
+ end
+
+ def cloneable_milestone_id
+ @new_project.milestones.find_by(title: @old_issue.milestone.try(:title))
+ end
+
def rewrite_notes
@old_issue.notes.find_each do |note|
new_note = note.dup
diff --git a/spec/services/issues/move_service_spec.rb b/spec/services/issues/move_service_spec.rb
index 2a5e4ac3ec4..c98e60d76b3 100644
--- a/spec/services/issues/move_service_spec.rb
+++ b/spec/services/issues/move_service_spec.rb
@@ -21,6 +21,15 @@ describe Issues::MoveService, services: true do
before do
old_project.team << [user, :reporter]
new_project.team << [user, :reporter]
+
+ create(:milestone, project_id: old_project.id, title: 'v1.0')
+ create(:milestone, project_id: new_project.id, title: 'v1.0')
+
+ old_issue.labels << create(:label, project_id: old_project.id, title: 'label1')
+ old_issue.labels << create(:label, project_id: old_project.id, title: 'label2')
+
+ new_project.labels << create(:label, title: 'label1')
+ new_project.labels << create(:label, title: 'label2')
end
end
@@ -39,6 +48,17 @@ describe Issues::MoveService, services: true do
expect(new_issue.project).to eq new_project
end
+ it 'assigns milestone to new issue' do
+ expect(new_issue.reload.milestone.title).to eq 'v1.0'
+ end
+
+ it 'assign labels to new issue' do
+ expected_label_titles = new_issue.reload.labels.map(&:title)
+ expect(expected_label_titles).to include 'label1'
+ expect(expected_label_titles).to include 'label2'
+ expect(expected_label_titles.size).to eq 2
+ end
+
it 'rewrites issue title' do
expect(new_issue.title).to eq title
end