diff options
| author | Douwe Maan <douwe@gitlab.com> | 2018-09-12 14:23:34 +0000 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2018-09-12 14:23:34 +0000 |
| commit | 5ad87599861849df6160df3781b47694a136a0ae (patch) | |
| tree | 4ccee5f6367f0d5268712e46135f8ab7e96d6188 | |
| parent | 2753fe6dba696b6daf853091acf041d6c459d771 (diff) | |
| parent | 88e3d76d16c2b55866bfabfdd841257b630b7912 (diff) | |
| download | gitlab-ce-5ad87599861849df6160df3781b47694a136a0ae.tar.gz | |
Merge branch 'code_review-assign-maintainers-different-team' into 'master'
Update code_review.md to include a recommendation for assigning maintainers from different teams
See merge request gitlab-org/gitlab-ce!21644
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e50e6370c80..edf0b6f46df 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -27,8 +27,9 @@ There are a few rules to get your merge request accepted: ask or assign any [reviewers][projects] for a first review. 1. If you need some guidance (e.g. it's your first merge request), feel free to ask one of the [Merge request coaches][team]. - 1. The reviewer will assign the merge request to a maintainer once the - reviewer is satisfied with the state of the merge request. + 1. It is recommended that you assign a maintainer that is from a different team than your own. + This ensures that all code across GitLab is consistent and can be easily understood by all contributors. + 1. Keep in mind that maintainers are also going to perform a final code review. The ideal scenario is that the reviewer has already addressed any concerns the maintainer would have found, and the maintainer only has to perform the |