diff options
| author | Luke Bennett <lbennett@gitlab.com> | 2018-09-10 12:03:55 +0000 |
|---|---|---|
| committer | Luke Bennett <lbennett@gitlab.com> | 2018-09-12 14:29:50 +0100 |
| commit | 88e3d76d16c2b55866bfabfdd841257b630b7912 (patch) | |
| tree | 68e766d7fa44d19b8eaf6fb2723edfa834949303 | |
| parent | 53fceedc1854108d1c51a533e1d4506c40385168 (diff) | |
| download | gitlab-ce-88e3d76d16c2b55866bfabfdd841257b630b7912.tar.gz | |
Update code_review.md to include a recommendation for assigning maintainers from different teams
Improve recommended maintainer docs
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e50e6370c80..edf0b6f46df 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -27,8 +27,9 @@ There are a few rules to get your merge request accepted: ask or assign any [reviewers][projects] for a first review. 1. If you need some guidance (e.g. it's your first merge request), feel free to ask one of the [Merge request coaches][team]. - 1. The reviewer will assign the merge request to a maintainer once the - reviewer is satisfied with the state of the merge request. + 1. It is recommended that you assign a maintainer that is from a different team than your own. + This ensures that all code across GitLab is consistent and can be easily understood by all contributors. + 1. Keep in mind that maintainers are also going to perform a final code review. The ideal scenario is that the reviewer has already addressed any concerns the maintainer would have found, and the maintainer only has to perform the |