diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2016-12-01 16:53:11 +0800 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2016-12-01 17:18:11 +0800 |
commit | 7075f47b08aad496ff644e8e132b4f142958e4c7 (patch) | |
tree | b725690f1cb66361b9249ea8d903586bde3f0343 | |
parent | 3f6667c2a5376d2411940c135879300f0928f468 (diff) | |
download | gitlab-ce-7075f47b08aad496ff644e8e132b4f142958e4c7.tar.gz |
No need to use transaction here, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7831#note_19224305
-rw-r--r-- | app/services/projects/destroy_service.rb | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/app/services/projects/destroy_service.rb b/app/services/projects/destroy_service.rb index f7cadb6a8ab..494747f1a54 100644 --- a/app/services/projects/destroy_service.rb +++ b/app/services/projects/destroy_service.rb @@ -96,11 +96,9 @@ module Projects end def async_execute - Project.transaction do - project.update_attribute(:pending_delete, true) - job_id = ProjectDestroyWorker.perform_async(project.id, current_user.id, params) - Rails.logger.info("User #{current_user.id} scheduled destruction of project #{project.path_with_namespace} with job ID #{job_id}") - end + project.update_attribute(:pending_delete, true) + job_id = ProjectDestroyWorker.perform_async(project.id, current_user.id, params) + Rails.logger.info("User #{current_user.id} scheduled destruction of project #{project.path_with_namespace} with job ID #{job_id}") end def execute |