Merge branch 'fix-danger-when-nobody-in-category' into 'master'

Fix reviewer roulette when no-one is in a category

See merge request gitlab-org/gitlab-ce!27895

1 files changed, 3 insertions, 1 deletions

diff --git a/danger/roulette/Dangerfile b/danger/roulette/Dangerfile
index 27763052192..62e5526c02b 100644
--- a/danger/roulette/Dangerfile
+++ b/danger/roulette/Dangerfile
@@ -57,10 +57,12 @@ def spin_for_person(people, random:)
   people.size.times do
     person = people.sample(random: random)
 
-    return person unless out_of_office?(person)
+    break person unless out_of_office?(person)
 
     people -= [person]
   end
+
+  person
 end
 
 def out_of_office?(person)