diff options
| author | Achilleas Pipinellis <axil@gitlab.com> | 2019-06-24 16:53:17 +0000 |
|---|---|---|
| committer | Achilleas Pipinellis <axil@gitlab.com> | 2019-06-24 16:53:17 +0000 |
| commit | 7f6de7fe29c2731975166b1a864c5a5cf3141132 (patch) | |
| tree | eab9c5aee1548c9b938ebf0e5c7a35c5681c5d3c | |
| parent | e5d8d15da0c3cf68fa9357b856a6b8a9877770b8 (diff) | |
| parent | 942b38d5af047bfcbf10f42a4e553caf8d305bc2 (diff) | |
| download | gitlab-ce-7f6de7fe29c2731975166b1a864c5a5cf3141132.tar.gz | |
Merge branch 'ab-codereview-db' into 'master'
Require database reviews for migrations
See merge request gitlab-org/gitlab-ce!29895
| -rw-r--r-- | doc/development/code_review.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 29e2aa1a581..6123f9f845a 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -60,6 +60,8 @@ from teams other than your own. 1. If your merge request includes backend changes [^1], it must be **approved by a [backend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_backend)**. + 1. If your merge request includes database migrations or changes to expensive queries [^2], it must be + **approved by a [database maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_database)**. 1. If your merge request includes frontend changes [^1], it must be **approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_frontend)**. 1. If your merge request includes UX changes [^1], it must be @@ -377,3 +379,4 @@ Largely based on the [thoughtbot code review guide]. [team]: https://about.gitlab.com/team/ [build handbook]: https://about.gitlab.com/handbook/build/handbook/build#how-to-work-with-build [^1]: Please note that specs other than JavaScript specs are considered backend code. +[^2]: We encourage you to seek guidance from a database maintainer if your merge request is potentially introducing expensive queries. It is most efficient to comment on the line of code in question with the SQL queries so they can give their advice. |