summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTed Hogan <ted.hogan17@gmail.com>2015-11-23 11:36:47 -0700
committerTed Hogan <ted.hogan17@gmail.com>2015-11-23 11:52:43 -0700
commit6e6a99061dbec4bb45a398a03e8a13a084e44035 (patch)
tree92d6f72d767a1236374bd0b8c33ba42b1240c909
parent36f7b624be0926b45b6a45aabea2beecfba72e50 (diff)
downloadgitlab-ce-6e6a99061dbec4bb45a398a03e8a13a084e44035.tar.gz
No space required after WIP identifier
Modified changelog
-rw-r--r--CHANGELOG1
-rw-r--r--app/models/merge_request.rb2
-rw-r--r--spec/models/merge_request_spec.rb15
3 files changed, 17 insertions, 1 deletions
diff --git a/CHANGELOG b/CHANGELOG
index fc7b6e75b1d..2453b35ead3 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.3.0 (unreleased)
- Fix: Assignee selector is empty when 'Unassigned' is selected (Jose Corcuera)
+ - WIP identifier on merge requests no longer requires trailing space
v 8.2.0
- Improved performance of finding projects and groups in various places
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index 1b3d6079d2c..2b336ca8927 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -239,7 +239,7 @@ class MergeRequest < ActiveRecord::Base
end
def work_in_progress?
- !!(title =~ /\A\[?WIP\]?:? /i)
+ !!(title =~ /\A\[?WIP(\]|:| )/i)
end
def mergeable?
diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb
index 567c911425c..edf211c85c1 100644
--- a/spec/models/merge_request_spec.rb
+++ b/spec/models/merge_request_spec.rb
@@ -162,6 +162,21 @@ describe MergeRequest do
expect(subject).to be_work_in_progress
end
+ it "detects the 'WIP' prefix" do
+ subject.title = "WIP#{subject.title}"
+ expect(subject).to be_work_in_progress
+ end
+
+ it "detects the 'WIP:' prefix" do
+ subject.title = "WIP:#{subject.title}"
+ expect(subject).to be_work_in_progress
+ end
+
+ it "detects the '[WIP]' prefix" do
+ subject.title = "[WIP]#{subject.title}"
+ expect(subject).to be_work_in_progress
+ end
+
it "doesn't detect WIP for words starting with WIP" do
subject.title = "Wipwap #{subject.title}"
expect(subject).not_to be_work_in_progress