summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Koltsov <gkoltsov@gitlab.com>2019-08-09 11:05:02 +0100
committerGeorge Koltsov <gkoltsov@gitlab.com>2019-08-12 15:05:49 +0100
commit23dfc5d60650d099d7f2b95af64f88e82edb3f4d (patch)
treeecee38193bdbf5a61994df6ef02df0734b4befde
parentba429a6e2023242a55f9199b1381ac331cc92e1c (diff)
downloadgitlab-ce-23dfc5d60650d099d7f2b95af64f88e82edb3f4d.tar.gz
Add code review suggestions
-rw-r--r--lib/gitlab/bitbucket_import/importer.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/gitlab/bitbucket_import/importer.rb b/lib/gitlab/bitbucket_import/importer.rb
index 9560b187292..24bc73e0de5 100644
--- a/lib/gitlab/bitbucket_import/importer.rb
+++ b/lib/gitlab/bitbucket_import/importer.rb
@@ -262,17 +262,17 @@ module Gitlab
def pull_request_comment_attributes(comment)
{
project: project,
- note: comment_note(comment),
author_id: gitlab_user_id(project, comment.author),
+ note: comment_note(comment),
created_at: comment.created_at,
updated_at: comment.updated_at
}
end
def comment_note(comment)
- note = ''
- note += @formatter.author_line(comment.author) unless find_user_id(comment.author)
- note + comment.note
+ author = @formatter.author_line(comment.author) unless find_user_id(comment.author)
+
+ author.to_s + comment.note.to_s
end
def log_error(details)