diff options
author | Kushal Pandya <kushalspandya@gmail.com> | 2019-08-30 07:11:37 +0000 |
---|---|---|
committer | Kushal Pandya <kushalspandya@gmail.com> | 2019-08-30 07:11:37 +0000 |
commit | 4a67f74d4feaead42de2b1bfb65e3c25f49b4b8d (patch) | |
tree | ff4a9108bd94b3539759da6b30efc45096c2ff4f | |
parent | b1af2a78a23f76bd1daec52d5ce6c729dde26948 (diff) | |
parent | ade2a5a6443461b98d90e34e53dc34142594667e (diff) | |
download | gitlab-ce-4a67f74d4feaead42de2b1bfb65e3c25f49b4b8d.tar.gz |
Merge branch 'nfriend-add-anchor-tag-to-release-block' into 'master'
Add `id` attribute to release blocks
See merge request gitlab-org/gitlab-ce!32360
-rw-r--r-- | app/assets/javascripts/releases/components/release_block.vue | 2 | ||||
-rw-r--r-- | spec/javascripts/releases/components/release_block_spec.js | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/assets/javascripts/releases/components/release_block.vue b/app/assets/javascripts/releases/components/release_block.vue index 7580c2d0ad0..88b6b4732b1 100644 --- a/app/assets/javascripts/releases/components/release_block.vue +++ b/app/assets/javascripts/releases/components/release_block.vue @@ -53,7 +53,7 @@ export default { }; </script> <template> - <div class="card"> + <div :id="release.tag_name" class="card"> <div class="card-body"> <h2 class="card-title mt-0"> {{ release.name }} diff --git a/spec/javascripts/releases/components/release_block_spec.js b/spec/javascripts/releases/components/release_block_spec.js index f761a18e326..fdf23f3f69d 100644 --- a/spec/javascripts/releases/components/release_block_spec.js +++ b/spec/javascripts/releases/components/release_block_spec.js @@ -88,6 +88,10 @@ describe('Release block', () => { vm.$destroy(); }); + it("renders the block with an id equal to the release's tag name", () => { + expect(vm.$el.id).toBe('18.04'); + }); + it('renders release name', () => { expect(vm.$el.textContent).toContain(release.name); }); |