Optimize querySelectors in user_overview_block.js

1 files changed, 7 insertions, 5 deletions

diff --git a/app/assets/javascripts/pages/users/user_overview_block.js b/app/assets/javascripts/pages/users/user_overview_block.js
index 5eba24a45b5..2ba1edc3a8a 100644
--- a/app/assets/javascripts/pages/users/user_overview_block.js
+++ b/app/assets/javascripts/pages/users/user_overview_block.js
@@ -15,7 +15,8 @@ export default class UserOverviewBlock {
   }
 
   loadData() {
-    const loadingEl = document.querySelector(`${this.container} .loading`);
+    const containerEl = document.querySelector(this.container);
+    const loadingEl = containerEl.querySelector(`.loading`);
 
     loadingEl.classList.remove('hide');
 
@@ -29,16 +30,17 @@ export default class UserOverviewBlock {
 
   render(data) {
     const { html, count } = data;
-    const contentList = document.querySelector(`${this.container} .overview-content-list`);
+    const containerEl = document.querySelector(this.container);
+    const contentList = containerEl.querySelector(`.overview-content-list`);
 
     contentList.innerHTML += html;
 
-    const loadingEl = document.querySelector(`${this.container} .loading`);
+    const loadingEl = containerEl.querySelector(`.loading`);
 
     if (count && count > 0) {
-      document.querySelector(`${this.container} .js-view-all`).classList.remove('hide');
+      containerEl.querySelector(`.js-view-all`).classList.remove('hide');
     } else {
-      document.querySelector(`${this.container} .nothing-here-block`).classList.add('p-0');
+      containerEl.querySelector(`.nothing-here-block`).classList.add('p-0');
     }
 
     loadingEl.classList.add('hide');