summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2018-01-09 23:50:27 +0100
committerFatih Acet <acetfatih@gmail.com>2018-01-09 23:50:27 +0100
commitb560b3bc2c1fe431c68b5293e852725ecf891d85 (patch)
treea7decfe3d63455b13b598f2d572a8d263f54dfca
parentb28072ddf962218dc1d0a77127fa78718e751d79 (diff)
downloadgitlab-ce-b560b3bc2c1fe431c68b5293e852725ecf891d85.tar.gz
MRNotesRefactor: Fix adding emojis from non Vue discussions.
-rw-r--r--app/assets/javascripts/awards_handler.js9
1 files changed, 7 insertions, 2 deletions
diff --git a/app/assets/javascripts/awards_handler.js b/app/assets/javascripts/awards_handler.js
index 4d6e875c7f0..f93b98a28f2 100644
--- a/app/assets/javascripts/awards_handler.js
+++ b/app/assets/javascripts/awards_handler.js
@@ -241,7 +241,7 @@ class AwardsHandler {
addAward(votesBlock, awardUrl, emoji, checkMutuality, callback) {
const isMainAwardsBlock = votesBlock.closest('.js-issue-note-awards').length;
- const vueDiscussions = isInIssuePage() || (isInMRPage && Cookies.get('vue_mr_discussions'));
+ const vueDiscussions = isInIssuePage() || this.isVueMRDiscussions();
if (vueDiscussions && !isMainAwardsBlock) {
const id = votesBlock.attr('id').replace('note_', '');
@@ -294,8 +294,13 @@ class AwardsHandler {
}
}
+ isVueMRDiscussions() {
+ return isInMRPage() && Cookies.get('vue_mr_discussions') && !$('#diffs:visible').length;
+ }
+
getVotesBlock() {
- const vueDiscussions = isInIssuePage() || (isInMRPage && Cookies.get('vue_mr_discussions'));
+ const vueDiscussions = isInIssuePage() || this.isVueMRDiscussions();
+
if (vueDiscussions) {
const $el = $('.js-add-award.is-active').closest('.note.timeline-entry');