diff options
| author | Eric Eastwood <contact@ericeastwood.com> | 2017-11-21 15:36:15 -0600 |
|---|---|---|
| committer | Eric Eastwood <contact@ericeastwood.com> | 2017-11-28 10:53:01 -0600 |
| commit | 078ba6a2d677abeea7b4bf4090fd0577e94b6ff5 (patch) | |
| tree | 107a4825dbfb1364bcf122b595aa42390ae20be3 | |
| parent | 52f5259ae40cfd868c6412ba10e28dc83877afbb (diff) | |
| download | gitlab-ce-078ba6a2d677abeea7b4bf4090fd0577e94b6ff5.tar.gz | |
Fix issue comment submit button disabled on GFM paste
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/40373
When copying some text from another note and paste,
it goes through `copy_as_gfm` `paste` handler
that calls `e.preventDefault()` which stops things.
But then when inserting the text, we manually trigger
an `input` event with jQuery which doesn't seem to be
picked up by Vue `v-model`.
Using copy/paste trick from https://stackoverflow.com/a/41046276/796832
| -rw-r--r-- | app/assets/javascripts/lib/utils/common_utils.js | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/40373-fix-issue-note-submit-disabled-on-paste.yml | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/app/assets/javascripts/lib/utils/common_utils.js b/app/assets/javascripts/lib/utils/common_utils.js index 6fa1e84c170..33cc807912c 100644 --- a/app/assets/javascripts/lib/utils/common_utils.js +++ b/app/assets/javascripts/lib/utils/common_utils.js @@ -190,7 +190,7 @@ export const insertText = (target, text) => { target.selectionStart = target.selectionEnd = selectionStart + insertedText.length; // Trigger autosave - $(target).trigger('input'); + target.dispatchEvent(new Event('input')); // Trigger autosize const event = document.createEvent('Event'); diff --git a/changelogs/unreleased/40373-fix-issue-note-submit-disabled-on-paste.yml b/changelogs/unreleased/40373-fix-issue-note-submit-disabled-on-paste.yml new file mode 100644 index 00000000000..e683e60397e --- /dev/null +++ b/changelogs/unreleased/40373-fix-issue-note-submit-disabled-on-paste.yml @@ -0,0 +1,6 @@ +--- +title: Fix Issue comment submit button being disabled when pasting content from another + GFM note +merge_request: 15530 +author: +type: fixed |