diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2019-01-09 10:24:47 +0000 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2019-01-09 10:24:47 +0000 |
| commit | 4f79bd780a07f5cf4aa085c30de7c95132c8aa91 (patch) | |
| tree | ea49cf0993d622d8167e1825b14bc7ead1596eb3 | |
| parent | b7b7d014f57c64d1324e2230dfecd1953bc47df5 (diff) | |
| download | gitlab-ce-4f79bd780a07f5cf4aa085c30de7c95132c8aa91.tar.gz | |
Adds skeleton loading for releases
In releases page, instead of rendering
a loading icon, it now renders the skeleton loading
| -rw-r--r-- | app/assets/javascripts/releases/components/app.vue | 6 | ||||
| -rw-r--r-- | changelogs/unreleased/55242-skeleton-loading-releases.yml | 5 |
2 files changed, 8 insertions, 3 deletions
diff --git a/app/assets/javascripts/releases/components/app.vue b/app/assets/javascripts/releases/components/app.vue index 0ad5ee2915c..5a06c4fec58 100644 --- a/app/assets/javascripts/releases/components/app.vue +++ b/app/assets/javascripts/releases/components/app.vue @@ -1,12 +1,12 @@ <script> import { mapState, mapActions } from 'vuex'; -import { GlLoadingIcon, GlEmptyState } from '@gitlab/ui'; +import { GlSkeletonLoading, GlEmptyState } from '@gitlab/ui'; import ReleaseBlock from './release_block.vue'; export default { name: 'ReleasesApp', components: { - GlLoadingIcon, + GlSkeletonLoading, GlEmptyState, ReleaseBlock, }, @@ -43,7 +43,7 @@ export default { </script> <template> <div class="prepend-top-default"> - <gl-loading-icon v-if="isLoading" :size="2" class="js-loading prepend-top-20" /> + <gl-skeleton-loading v-if="isLoading" class="js-loading" /> <gl-empty-state v-else-if="shouldRenderEmptyState" diff --git a/changelogs/unreleased/55242-skeleton-loading-releases.yml b/changelogs/unreleased/55242-skeleton-loading-releases.yml new file mode 100644 index 00000000000..43cda64ce04 --- /dev/null +++ b/changelogs/unreleased/55242-skeleton-loading-releases.yml @@ -0,0 +1,5 @@ +--- +title: Adds skeleton loading to releases page +merge_request: +author: +type: changed |