summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorddavison <ddavison@gitlab.com>2018-07-26 13:06:44 -0400
committerddavison <ddavison@gitlab.com>2018-07-26 13:06:44 -0400
commit9a780b39945b6a5033adc63c1a3c7a92f9f6c74f (patch)
treed3d00886d092592106f3ba1ec7d25a1879fb8a19
parentf5c13cca6db4c04f3642697d126fd7b34e515cac (diff)
downloadgitlab-ce-9a780b39945b6a5033adc63c1a3c7a92f9f6c74f.tar.gz
s/should call/calls
removing runs smoke tests example fixing spec to check smoke tegs fixing pathing
-rw-r--r--qa/spec/scenario/test/instance/all_spec.rb8
-rw-r--r--qa/spec/scenario/test/instance/smoke_spec.rb8
2 files changed, 7 insertions, 9 deletions
diff --git a/qa/spec/scenario/test/instance/all_spec.rb b/qa/spec/scenario/test/instance/all_spec.rb
index 62732e18973..bc0b21c6494 100644
--- a/qa/spec/scenario/test/instance/all_spec.rb
+++ b/qa/spec/scenario/test/instance/all_spec.rb
@@ -12,8 +12,6 @@ describe QA::Scenario::Test::Instance::All do
allow(runner).to receive(:perform).and_yield(runner)
end
- it 'runs smoke tests'
-
it 'sets an address of the subject' do
subject.perform("hello")
@@ -22,16 +20,16 @@ describe QA::Scenario::Test::Instance::All do
end
context 'no paths' do
- it 'should call runner with default arguments' do
+ it 'calls runner with default arguments' do
subject.perform("test")
expect(runner).to have_received(:options=)
- .with(::File.expand_path('../../../../qa/specs/features', __dir__))
+ .with(::File.expand_path('../../../../../qa/specs/features', __dir__))
end
end
context 'specifying paths' do
- it 'should call runner with paths' do
+ it 'calls runner with paths' do
subject.perform('test', 'path1', 'path2')
expect(runner).to have_received(:options=).with(%w[path1 path2])
diff --git a/qa/spec/scenario/test/instance/smoke_spec.rb b/qa/spec/scenario/test/instance/smoke_spec.rb
index f7fa1ac047e..b2ff2178368 100644
--- a/qa/spec/scenario/test/instance/smoke_spec.rb
+++ b/qa/spec/scenario/test/instance/smoke_spec.rb
@@ -22,20 +22,20 @@ describe QA::Scenario::Test::Instance::Smoke do
end
it 'has a smoke tag' do
- expect(subject.tags).to eq([:smoke])
+ expect(subject.focus).to eq([:smoke])
end
context 'no paths' do
- it 'should call runner with default arguments' do
+ it 'calls runner with default arguments' do
subject.perform("test")
expect(runner).to have_received(:options=)
- .with(File.expand_path('../../../../qa/specs/features', __dir__))
+ .with(File.expand_path('../../../../../qa/specs/features', __dir__))
end
end
context 'specifying paths' do
- it 'should call runner with paths' do
+ it 'calls runner with paths' do
subject.perform('test', 'path1', 'path2')
expect(runner).to have_received(:options=).with(%w[path1 path2])