summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Thomas <nick@gitlab.com>2018-04-27 12:13:31 +0000
committerNick Thomas <nick@gitlab.com>2018-04-27 12:13:31 +0000
commitc45b7ab597b5fa2bf48fa0f181e4d58a2c0b3a09 (patch)
tree52d5a4ce18ca42d32195b4edb3c077b159a48d0b
parent1b2a94c178efe7c6c0770601c58219dca6ab8bfd (diff)
parentbb650ad05240a54497599b6a884ac0f7f8fa1629 (diff)
downloadgitlab-ce-c45b7ab597b5fa2bf48fa0f181e4d58a2c0b3a09.tar.gz
Merge branch 'jivl-revert-system-notes-can-be-confusing' into 'master'
Remove comma from the time system notes See merge request gitlab-org/gitlab-ce!18593
-rw-r--r--app/services/system_note_service.rb2
-rw-r--r--spec/services/system_note_service_spec.rb8
2 files changed, 2 insertions, 8 deletions
diff --git a/app/services/system_note_service.rb b/app/services/system_note_service.rb
index 958ef065012..00bf5434b7f 100644
--- a/app/services/system_note_service.rb
+++ b/app/services/system_note_service.rb
@@ -159,7 +159,7 @@ module SystemNoteService
body = if noteable.time_estimate == 0
"removed time estimate"
else
- "changed time estimate to #{parsed_time},"
+ "changed time estimate to #{parsed_time}"
end
create_note(NoteSummary.new(noteable, project, author, body, action: 'time_tracking'))
diff --git a/spec/services/system_note_service_spec.rb b/spec/services/system_note_service_spec.rb
index 893804f1470..e28b0ea5cf2 100644
--- a/spec/services/system_note_service_spec.rb
+++ b/spec/services/system_note_service_spec.rb
@@ -909,13 +909,7 @@ describe SystemNoteService do
it 'sets the note text' do
noteable.update_attribute(:time_estimate, 277200)
- expect(subject.note).to eq "changed time estimate to 1w 4d 5h,"
- end
-
- it 'appends a comma to separate the note from the update_at time' do
- noteable.update_attribute(:time_estimate, 277200)
-
- expect(subject.note).to end_with(',')
+ expect(subject.note).to eq "changed time estimate to 1w 4d 5h"
end
end