summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Zallmann <tzallmann@gitlab.com>2017-10-12 11:35:16 +0200
committerTim Zallmann <tzallmann@gitlab.com>2017-10-30 10:28:33 +0100
commit33ca696666e8acb7ebaa427bfe0ed8f8d9471d77 (patch)
tree9bdbfbba23ff50918178c208faa033731d54d513
parent38a986624289b85cebc0b3548fa0a5690f65505a (diff)
downloadgitlab-ce-33ca696666e8acb7ebaa427bfe0ed8f8d9471d77.tar.gz
Fixing Tests and CSS display
-rw-r--r--app/assets/stylesheets/pages/pipelines.scss12
-rw-r--r--app/views/ci/status/_dropdown_graph_badge.html.haml4
-rw-r--r--spec/features/projects/pipelines/pipeline_spec.rb12
3 files changed, 18 insertions, 10 deletions
diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss
index c0e16b37ad7..c24b780052d 100644
--- a/app/assets/stylesheets/pages/pipelines.scss
+++ b/app/assets/stylesheets/pages/pipelines.scss
@@ -725,9 +725,9 @@ button.mini-pipeline-graph-dropdown-toggle {
fill: $gl-text-color-secondary;
width: $ci-action-icon-size;
height: $ci-action-icon-size;
- left: -6px;
+ left: -3px;
position: relative;
- top: -3px;
+ top: 0;
}
&:hover svg,
@@ -743,6 +743,14 @@ button.mini-pipeline-graph-dropdown-toggle {
left: 8px;
}
}
+
+ svg.icon-action-play,
+ svg.icon-action-stop {
+ width: 12px;
+ height: 12px;
+ top: 1px;
+ left: 0;
+ }
}
// link to the build
diff --git a/app/views/ci/status/_dropdown_graph_badge.html.haml b/app/views/ci/status/_dropdown_graph_badge.html.haml
index 9596bf00f75..c5b4439e273 100644
--- a/app/views/ci/status/_dropdown_graph_badge.html.haml
+++ b/app/views/ci/status/_dropdown_graph_badge.html.haml
@@ -15,5 +15,5 @@
%span.ci-build-text= subject.name
- if status.has_action?
- = link_to status.action_path, class: 'ci-action-icon-wrapper js-ci-action-icon', method: status.action_method, data: { toggle: 'tooltip', title: status.action_title, container: 'body' } do
- = sprite_icon(status.action_icon)
+ = link_to status.action_path, class: "ci-action-icon-wrapper js-ci-action-icon", method: status.action_method, data: { toggle: 'tooltip', title: status.action_title, container: 'body' } do
+ = sprite_icon(status.action_icon, css_class: "icon-action-#{status.action_icon}")
diff --git a/spec/features/projects/pipelines/pipeline_spec.rb b/spec/features/projects/pipelines/pipeline_spec.rb
index 70f476382a8..931811e0ee6 100644
--- a/spec/features/projects/pipelines/pipeline_spec.rb
+++ b/spec/features/projects/pipelines/pipeline_spec.rb
@@ -86,8 +86,8 @@ describe 'Pipeline', :js do
expect(page).to have_content('build')
end
- page.within('#ci-badge-build .ci-action-icon-container') do
- expect(page).to have_selector('.js-icon-retry')
+ page.within('#ci-badge-build .ci-action-icon-container.js-icon-retry') do
+ expect(page).to have_selector('svg')
end
end
@@ -105,8 +105,8 @@ describe 'Pipeline', :js do
expect(page).to have_content('test')
end
- page.within('#ci-badge-test .ci-action-icon-container') do
- expect(page).to have_selector('.js-icon-retry')
+ page.within('#ci-badge-test .ci-action-icon-container.js-icon-retry') do
+ expect(page).to have_selector('svg')
end
end
@@ -124,8 +124,8 @@ describe 'Pipeline', :js do
expect(page).to have_content('manual')
end
- page.within('#ci-badge-manual-build .ci-action-icon-container') do
- expect(page).to have_selector('.js-icon-play')
+ page.within('#ci-badge-manual-build .ci-action-icon-container.js-icon-play') do
+ expect(page).to have_selector('svg')
end
end