Add IoC container which is CI config entry locatorrefactor/ci-config-logical-validation

2 files changed, 68 insertions, 0 deletions

diff --git a/lib/gitlab/ci/config/dependencies.rb b/lib/gitlab/ci/config/dependencies.rb
new file mode 100644
index 00000000000..9029e5f5155
--- /dev/null
+++ b/lib/gitlab/ci/config/dependencies.rb
@@ -0,0 +1,26 @@
+module Gitlab
+  module Ci
+    class Config
+      class Dependencies
+        class UnmetDependencyError < StandardError; end
+
+        def initialize
+          @entries = {}
+        end
+
+        def visit(entry)
+          @entries[entry.location] = entry
+          entry.dependencies = self
+        end
+
+        def entry(location)
+          unless @entries.has_key?(location)
+            raise UnmetDependencyError, "Unmet dependency #{location}"
+          end
+
+          @entries[location]
+        end
+      end
+    end
+  end
+end
diff --git a/spec/lib/gitlab/ci/config/dependencies_spec.rb b/spec/lib/gitlab/ci/config/dependencies_spec.rb
new file mode 100644
index 00000000000..4ed2e6ab300
--- /dev/null
+++ b/spec/lib/gitlab/ci/config/dependencies_spec.rb
@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe Gitlab::Ci::Config::Dependencies do
+  let(:entry) { double('Entry') }
+
+  before do
+    allow(entry).to receive(:location).and_return('test:entry')
+    allow(entry).to receive(:dependencies=)
+  end
+
+  describe '#visit' do
+    it 'adds entry to registry' do
+      subject.visit(entry)
+
+      expect(subject.entry('test:entry')).to be entry
+    end
+
+    it 'sets itself as a service locator' do
+      expect(entry).to receive(:dependencies=).with(subject)
+
+      subject.visit(entry)
+    end
+  end
+
+  describe '#entry' do
+    context 'when entry location exists' do
+      it 'return entry object' do
+        subject.visit(entry)
+
+        expect(subject.entry('test:entry')).to be entry
+      end
+    end
+
+    context 'when entry location does not exist' do
+      it 'raises error' do
+        expect { subject.entry('no:entry') }.to raise_error(
+          Gitlab::Ci::Config::Dependencies::UnmetDependencyError
+        )
+      end
+    end
+  end
+end