diff options
| author | Nick Thomas <nick@gitlab.com> | 2019-02-18 10:31:04 +0000 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2019-02-18 10:31:04 +0000 |
| commit | 4e42168b09aeebef0481cb532822039b2111734d (patch) | |
| tree | 4f1d558af94b96e379db7a75fdeef4986fdd3152 | |
| parent | 08271ba496fa9ee2cd8a3e004f4a851a16f124bf (diff) | |
| parent | 633cb37e288163e1cca7c5bc2721105dcfea48a9 (diff) | |
| download | gitlab-ce-4e42168b09aeebef0481cb532822039b2111734d.tar.gz | |
Merge branch 'docs/zj-reviewer-guidelines' into 'master'
Add a soft SLA for reviewers and maintainers
See merge request gitlab-org/gitlab-ce!25192
| -rw-r--r-- | doc/development/code_review.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 4e5fb47e331..1b591c7c322 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -137,6 +137,14 @@ If a developer who happens to also be a maintainer was involved in a merge reque as a domain expert and/or reviewer, it is recommended that they are not also picked as the maintainer to ultimately approve and merge it. +Try to review in a timely manner; doing so allows everyone involved in the merge +request to iterate faster as the context is fresh in memory. Further, this +improves contributors' experiences significantly. Reviewers should aim to review +within two working days from the date they were assigned the merge request. If +you don't think you'll be able to review a merge request within that time, let +the author know as soon as possible. When the author of the merge request has not +heard anything after two days, a new reviewer should be assigned. + Maintainers should check before merging if the merge request is approved by the required approvers. |