diff options
| author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-11-14 15:06:34 +0000 |
|---|---|---|
| committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-11-14 15:06:34 +0000 |
| commit | 7f151a7898bf6b836ba7ae0b53d718a1263b5d6f (patch) | |
| tree | d5ed8a389d47183664ef2e9be446e038f0fdf50c | |
| parent | 36fa5d660df96c49484cd27695da1df6e361eb8f (diff) | |
| parent | d9a0682d891e26a8ad0e5eb1a1b9b41d15fb5b27 (diff) | |
| download | gitlab-ce-7f151a7898bf6b836ba7ae0b53d718a1263b5d6f.tar.gz | |
Merge branch 'always-show-download-button' into 'master'
Project download buttons always show
## What does this MR do?
Removes `hidden-xs hidden-sm` classes from `download-button` so it doesn’t hide itself individually from the rest of the `project-repo-buttons` block
## Why was this MR needed?
Fixes #23960. Not sure why this element had these classes in the first place, but at the very least we shouldn’t be hiding the Download button at the `hidden-sm` threshold since that’s still fairly large viewport and users with viewports of that size likely still want to download source code.
## Screenshots (if relevant)
Screenshots taken at ~830px width
__Before__
__After__
## What are the relevant issue numbers?
#23960
See merge request !7405
| -rw-r--r-- | app/views/projects/buttons/_download.html.haml | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/always-show-download-button.yml | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/views/projects/buttons/_download.html.haml b/app/views/projects/buttons/_download.html.haml index 7e83a88913a..7b995bd8735 100644 --- a/app/views/projects/buttons/_download.html.haml +++ b/app/views/projects/buttons/_download.html.haml @@ -1,5 +1,5 @@ - if !project.empty_repo? && can?(current_user, :download_code, project) - %span{class: 'hidden-xs hidden-sm download-button'} + %span{class: 'download-button'} .dropdown.inline %button.btn{ 'data-toggle' => 'dropdown' } = icon('download') diff --git a/changelogs/unreleased/always-show-download-button.yml b/changelogs/unreleased/always-show-download-button.yml new file mode 100644 index 00000000000..3a625834d01 --- /dev/null +++ b/changelogs/unreleased/always-show-download-button.yml @@ -0,0 +1,4 @@ +--- +title: Project download buttons always show +merge_request: 7405 +author: Philip Karpiak |