summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWalmyr Lima <walmyr@gitlab.com>2019-07-18 18:50:58 +0200
committerWalmyr Lima <walmyr@gitlab.com>2019-07-18 18:50:58 +0200
commit3bded603974e7cd22e90be9911ba0fc08ca26b94 (patch)
treebb9352740a1a5a921436067bdffcf30eb2702a12
parent9967b2d1ee3644ed22fb441cc754f4e6764a7718 (diff)
downloadgitlab-ce-3bded603974e7cd22e90be9911ba0fc08ca26b94.tar.gz
Refactor check mentions for xss testqa/refactor-check-mentions-for-xss-spec
The refactor consists in: - Better scopping preconditions and the test definition - Removing a variable that was being used in a single palce, and use the string directly instead.
-rw-r--r--qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb
index 5eceeb9661c..afddbff75bd 100644
--- a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb
+++ b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb
@@ -3,9 +3,7 @@
module QA
context 'Plan' do
describe 'check xss occurence in @mentions in issues' do
- let(:issue_title) { 'issue title' }
-
- it 'user mentions a user in comment' do
+ before do
Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.perform(&:sign_in_using_credentials)
@@ -25,11 +23,13 @@ module QA
end
issue = Resource::Issue.fabricate_via_api! do |issue|
- issue.title = issue_title
+ issue.title = 'issue title'
issue.project = project
end
issue.visit!
+ end
+ it 'user mentions a user in comment' do
Page::Project::Issue::Show.perform do |show_page|
show_page.select_all_activities_filter
show_page.comment('cc-ing you here @eve')