summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTimothy Andrew <mail@timothyandrew.net>2017-06-20 03:11:16 +0000
committerTimothy Andrew <mail@timothyandrew.net>2017-07-06 06:30:07 +0000
commit56754848dddb5460500ab056e5ac1b9a61c7ff89 (patch)
treef2046ab371238497be470cc4f340a21837aedc10
parent1e9dfb73992e7586c4ee0503357df31925be593f (diff)
downloadgitlab-ce-56754848dddb5460500ab056e5ac1b9a61c7ff89.tar.gz
Don't allow the `gitlab:env:info` rake task to mutate the list of omniauth providers.
- The test for `rake gitlab:env:info` executed the rake task, which mutated the list of omniauth providers, breaking subsequent tests relying on this list. - I've changed the rake task to duplicate the providers list before modifying it.
-rw-r--r--lib/tasks/gitlab/info.rake2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/tasks/gitlab/info.rake b/lib/tasks/gitlab/info.rake
index e3883278886..2245dfb7828 100644
--- a/lib/tasks/gitlab/info.rake
+++ b/lib/tasks/gitlab/info.rake
@@ -42,7 +42,7 @@ namespace :gitlab do
http_clone_url = project.http_url_to_repo
ssh_clone_url = project.ssh_url_to_repo
- omniauth_providers = Gitlab.config.omniauth.providers
+ omniauth_providers = Gitlab.config.omniauth.providers.dup
omniauth_providers.map! { |provider| provider['name'] }
puts ""