diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-07-12 14:58:48 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-07-12 14:58:48 +0200 |
commit | b228787f5afa34b153e6b52d6b0d88248cc3e099 (patch) | |
tree | 6acf3b9ca83ec270a53ac26b646d61a1427055e0 | |
parent | 61f7bede79a006c7b44e88a3385d175c5ad2a863 (diff) | |
download | gitlab-ce-b228787f5afa34b153e6b52d6b0d88248cc3e099.tar.gz |
Do not raise when getting value of invalid CI node
-rw-r--r-- | lib/gitlab/ci/config/node/configurable.rb | 2 | ||||
-rw-r--r-- | spec/lib/gitlab/ci/config/node/global_spec.rb | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/lib/gitlab/ci/config/node/configurable.rb b/lib/gitlab/ci/config/node/configurable.rb index da2ef4d5503..8bd752b0e2a 100644 --- a/lib/gitlab/ci/config/node/configurable.rb +++ b/lib/gitlab/ci/config/node/configurable.rb @@ -55,7 +55,7 @@ module Gitlab end define_method("#{symbol}_value") do - raise Entry::InvalidError unless valid? + return unless valid? @entries[symbol].value if @entries[symbol] end diff --git a/spec/lib/gitlab/ci/config/node/global_spec.rb b/spec/lib/gitlab/ci/config/node/global_spec.rb index 1945b0326cc..3ffbe9c2e97 100644 --- a/spec/lib/gitlab/ci/config/node/global_spec.rb +++ b/spec/lib/gitlab/ci/config/node/global_spec.rb @@ -209,10 +209,8 @@ describe Gitlab::Ci::Config::Node::Global do end describe '#before_script' do - it 'raises error' do - expect { global.before_script }.to raise_error( - Gitlab::Ci::Config::Node::Entry::InvalidError - ) + it 'returns nil' do + expect(global.before_script).to be_nil end end end |