summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKamil Trzciński <ayufan@ayufan.eu>2017-02-23 14:36:53 +0000
committerKamil Trzciński <ayufan@ayufan.eu>2017-02-23 14:36:53 +0000
commitcfd7602dde35a2558563689b0a03f0eaf49b20fd (patch)
tree814da7395c3873eafe1353db5eb1db63dbf24fe5
parent7e662dc7cba5440ba21a0a928f035914c48bce37 (diff)
parent9e6b2c5dd4a1a58ca62650b6f529213bc730f64f (diff)
downloadgitlab-ce-cfd7602dde35a2558563689b0a03f0eaf49b20fd.tar.gz
Merge branch 'fix-test-for-build-attributes' into 'master'
Fix build attributes test See merge request !9409
-rw-r--r--app/services/ci/retry_build_service.rb7
-rw-r--r--spec/services/ci/retry_build_service_spec.rb4
2 files changed, 6 insertions, 5 deletions
diff --git a/app/services/ci/retry_build_service.rb b/app/services/ci/retry_build_service.rb
index 4b47ee489cf..38ef323f6e5 100644
--- a/app/services/ci/retry_build_service.rb
+++ b/app/services/ci/retry_build_service.rb
@@ -1,16 +1,17 @@
module Ci
class RetryBuildService < ::BaseService
- CLONE_ATTRIBUTES = %i[pipeline ref tag options commands tag_list name
+ CLONE_ATTRIBUTES = %i[pipeline project ref tag options commands name
allow_failure stage stage_idx trigger_request
yaml_variables when environment coverage_regex]
.freeze
REJECT_ATTRIBUTES = %i[id status user token coverage trace runner
- artifacts_file artifacts_metadata artifacts_size
+ artifacts_expire_at artifacts_file
+ artifacts_metadata artifacts_size
created_at updated_at started_at finished_at
queued_at erased_by erased_at].freeze
- IGNORE_ATTRIBUTES = %i[trace type lock_version project target_url
+ IGNORE_ATTRIBUTES = %i[type lock_version gl_project_id target_url
deploy job_id description].freeze
def execute(build)
diff --git a/spec/services/ci/retry_build_service_spec.rb b/spec/services/ci/retry_build_service_spec.rb
index 93147870afe..d03f7505eac 100644
--- a/spec/services/ci/retry_build_service_spec.rb
+++ b/spec/services/ci/retry_build_service_spec.rb
@@ -12,7 +12,7 @@ describe Ci::RetryBuildService, :services do
shared_examples 'build duplication' do
let(:build) do
- create(:ci_build, :failed, :artifacts, :erased, :trace,
+ create(:ci_build, :failed, :artifacts_expired, :erased, :trace,
:queued, :coverage, pipeline: pipeline)
end
@@ -38,7 +38,7 @@ describe Ci::RetryBuildService, :services do
described_class::IGNORE_ATTRIBUTES +
described_class::REJECT_ATTRIBUTES
- expect(attributes.size).to eq build.attributes.size
+ expect(build.attributes.size).to eq(attributes.size)
end
end