Simplify ci config entry validator implementation

1 files changed, 2 insertions, 7 deletions

diff --git a/lib/gitlab/ci/config/entry/validator.rb b/lib/gitlab/ci/config/entry/validator.rb
index 5ab54d7e218..83bca0d08bc 100644
--- a/lib/gitlab/ci/config/entry/validator.rb
+++ b/lib/gitlab/ci/config/entry/validator.rb
@@ -24,16 +24,11 @@ module Gitlab
           private
 
           def location
-            predecessors = ancestors.map(&:key).compact
-            predecessors.append(key_name).join(':')
+            ancestors.map(&:key).compact.append(key_name).join(':')
           end
 
           def key_name
-            if key.blank?
-              @entry.class.name.to_s.demodulize.underscore.humanize
-            else
-              key
-            end
+            key.presence || @entry.class.name.to_s.demodulize.underscore.humanize
           end
         end
       end