summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2019-04-02 03:51:38 +0000
committerStan Hu <stanhu@gmail.com>2019-04-02 03:51:38 +0000
commit264a6299583d32af41bd321b275d93a728bcaf72 (patch)
treef470d79e3064cf1968898da9e75fbfbcac8b4041
parentcde8456cd433c258e9100fe33f10f62a3b32ee4e (diff)
parentcfc6d2528cc8d632f16b23334795be537511cfef (diff)
downloadgitlab-ce-264a6299583d32af41bd321b275d93a728bcaf72.tar.gz
Merge branch 'weimeng-master-patch-83366' into 'master'
Fix attempting to drop views in PostgreSQL See merge request gitlab-org/gitlab-ce!26836
-rw-r--r--lib/tasks/gitlab/db.rake5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/tasks/gitlab/db.rake b/lib/tasks/gitlab/db.rake
index b94b21775ee..4e7a8adbef6 100644
--- a/lib/tasks/gitlab/db.rake
+++ b/lib/tasks/gitlab/db.rake
@@ -29,7 +29,10 @@ namespace :gitlab do
# If MySQL, turn off foreign key checks
connection.execute('SET FOREIGN_KEY_CHECKS=0') if Gitlab::Database.mysql?
- tables = connection.data_sources
+ # connection.tables is deprecated in MySQLAdapter, but in PostgreSQLAdapter
+ # data_sources returns both views and tables, so use #tables instead
+ tables = Gitlab::Database.mysql? ? connection.data_sources : connection.tables
+
# Removes the entry from the array
tables.delete 'schema_migrations'
# Truncate schema_migrations to ensure migrations re-run