summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAchilleas Pipinellis <axil@gitlab.com>2018-12-07 11:06:02 +0000
committerAchilleas Pipinellis <axil@gitlab.com>2018-12-07 11:06:02 +0000
commit77849a2c1d346d0c64b12d850fab771e4494b657 (patch)
tree1f1d177577024fb5fb5fd0ec4a1fa8f683be7ec9
parenta89a73c1cc8576d75afc947cec14f19e1ae8a30d (diff)
parent180d9375524f43157cb0aa3004f0531ebe5a3c19 (diff)
downloadgitlab-ce-77849a2c1d346d0c64b12d850fab771e4494b657.tar.gz
Merge branch 'docs/run-help-pages-tests' into 'master'
Document `/help` tests See merge request gitlab-org/gitlab-ce!23469
-rw-r--r--doc/development/documentation/index.md11
1 files changed, 11 insertions, 0 deletions
diff --git a/doc/development/documentation/index.md b/doc/development/documentation/index.md
index b7990e1b558..55aed023325 100644
--- a/doc/development/documentation/index.md
+++ b/doc/development/documentation/index.md
@@ -368,6 +368,16 @@ You can combine one or more of the following:
= link_to 'Help page', help_page_path('user/permissions')
```
+### GitLab `/help` tests
+
+Several [rspec tests](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/features/help_pages_spec.rb)
+are run to ensure GitLab documentation renders and works correctly. In particular, that [main docs landing page](../../README.md) will work correctly from `/help`.
+For example, [GitLab.com's `/help`](https://gitlab.com/help).
+
+CAUTION: **Caution:**
+Because the rspec tests only run in a full pipeline, and not a special [docs-only pipeline](#branch-naming), it is possible
+to merge changes that will break `master` from a merge request with a successful docs-only pipeline run.
+
## General Documentation vs Technical Articles
### General documentation
@@ -552,6 +562,7 @@ Currently, the following tests are in place:
As CE is merged into EE once a day, it's important to avoid merge conflicts.
Submitting an EE-equivalent merge request cherry-picking all commits from CE to EE is
essential to avoid them.
+1. In a full pipeline, tests for [`/help`](#gitlab-help-tests).
### Linting