diff options
author | Phil Hughes <me@iamphill.com> | 2017-01-24 15:51:15 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2017-02-03 17:02:43 +0300 |
commit | 7d0feab3abd1fa6459b9be81b340a9f9121d84b7 (patch) | |
tree | be4680e325959a321937e9a8c50b8680695bbe23 | |
parent | 48b3623fb5688bb5dfc3f1a5e2436c29afc968a2 (diff) | |
download | gitlab-ce-7d0feab3abd1fa6459b9be81b340a9f9121d84b7.tar.gz |
Fixes layout issue on selected tab
Fixed modal not closing on cancel clicked
-rw-r--r-- | app/assets/javascripts/boards/components/modal/footer.js.es6 | 9 | ||||
-rw-r--r-- | app/assets/javascripts/boards/components/modal/list.js.es6 | 10 |
2 files changed, 15 insertions, 4 deletions
diff --git a/app/assets/javascripts/boards/components/modal/footer.js.es6 b/app/assets/javascripts/boards/components/modal/footer.js.es6 index dec0196a32c..aadb754fd9e 100644 --- a/app/assets/javascripts/boards/components/modal/footer.js.es6 +++ b/app/assets/javascripts/boards/components/modal/footer.js.es6 @@ -7,9 +7,10 @@ gl.issueBoards.ModalFooter = Vue.extend({ data() { - return Object.assign({}, Store.modal, { + return { + store: Store.modal, disabled: false, - }); + }; }, computed: { submitDisabled() { @@ -25,10 +26,10 @@ }, methods: { hideModal() { - this.showAddIssuesModal = false; + this.store.showAddIssuesModal = false; }, addIssues() { - const issueIds = this.issues.filter(issue => issue.selected).map(issue => issue.id); + const issueIds = this.store.issues.filter(issue => issue.selected).map(issue => issue.id); this.disabled = true; }, diff --git a/app/assets/javascripts/boards/components/modal/list.js.es6 b/app/assets/javascripts/boards/components/modal/list.js.es6 index e700161f642..067a6322bca 100644 --- a/app/assets/javascripts/boards/components/modal/list.js.es6 +++ b/app/assets/javascripts/boards/components/modal/list.js.es6 @@ -19,6 +19,16 @@ this.initMasonry(); }); }, + issues: { + handler() { + if (this.activeTab === 'selected') { + this.$nextTick(() => { + listMasonry.layout(); + }); + } + }, + deep: true, + } }, computed: { loading() { |